Feature/client access tokens #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Henckens <jan@henckens.be>
Signed-off-by: Jan Henckens <jan@henckens.be>
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the JWT-based authentication mechanism with client access tokens. Key changes include updating AuthService to use clientId/clientSecret and OAuth endpoints, revising ApiService and EntryAPI constructors accordingly, and refreshing documentation and changelog to reflect the new authentication process.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/services/entry/AuthService.php | Updated constructor parameters, token refresh logic, and token persistence using the OAuth endpoint. |
| src/services/entry/ApiService.php | Updated constructor parameters and removed the deprecated X-Api-Key header. |
| src/Environments.php | Replaced getJWTUrl with getOAuthUrl and updated endpoint URLs accordingly. |
| src/EntryAPI.php | Modified constructor to accept clientId and clientSecret. |
| README.md | Updated environment variable names and removed outdated JWT token instructions. |
| CHANGELOG.md | Documented the switch from JWT authentication to client access tokens. |
Comments suppressed due to low confidence (1)
src/services/entry/AuthService.php:95
- The updateAccessToken() method now writes the raw response body to the storage file. Ensure that the body format (e.g., a JSON with an 'access_token' key) is consistently maintained so that getAccessToken() can parse it correctly.
$body
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reason for this change