Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Properly screenshot a website that uses CSS animations #60

Open
fransallen opened this issue Jan 24, 2020 · 8 comments
Labels
enhancement New feature or request

Comments

@fransallen
Copy link
Member

I would like to suggest a feature request for the screenshot feature. It works well but not for those pages which has CSS animations on the content/section. That ends up with incorrect screenshots. How about adding a delay timer parameter to take the screenshot? Or wait for the page to load fully before taking a screenshot?

Originally posted by @munirkamal in #30 (comment)

@fransallen
Copy link
Member Author

Hi @munirkamal, I moved this as a separate issue for better discovery.

I use Puppeteer, so something like waitUntil: 'networkidle0' might work.

I am currently still having an issue where I reached a timeout limit for this and returned an error page instead of an image, this is because I am still using a free ZEIT account, I am in the process of contacting them to get more limits, but if someone can help contact them, I'll be very grateful.

@munirkamal
Copy link

Hi @fransallen,

Yes, delay option or something which triggers when page fully loads would do the job well. This feature will really be a great help for the screenshot feature. Many websites now use some kind of animations/interactions and taking the screenshot without delay or when page fully loads causes incorrect screenshot.

I am really hoping you get this sorted with ZEIT or another way.

Looking forward to this.

@fransallen fransallen added the enhancement New feature or request label Feb 26, 2020
@munirkamal
Copy link

Hey awesome fellows,
Any updates on this?

TIA

@fransallen
Copy link
Member Author

Hi @munirkamal not yet, but this will come, please stay tuned.

@anuraghazra
Copy link

anuraghazra commented Jul 14, 2020

@fransallen
Copy link
Member Author

Will do some tests and see if it is a suitable workaround here. Thanks, @anuraghazra.

@fransallen
Copy link
Member Author

Since Statically Screenshot is now an open-source software, anyone is welcome to contribute to the repo and make the software even better, good luck 🔥

https://github.com/staticallyio/screenshot

@gabrielbeauchemin
Copy link

gabrielbeauchemin commented Jun 17, 2021

Is it still a work in progress? I think it should be in the API, as animations are used a lot and without that, that make the tests flaky.

Also, a thing to consider I think is that it should work also with element under shadow root. Thanks for you work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants