Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long running tests seems to stall closing ledgers occasionally #130

Closed
lalexgap opened this issue Oct 7, 2022 · 1 comment
Closed

Long running tests seems to stall closing ledgers occasionally #130

lalexgap opened this issue Oct 7, 2022 · 1 comment
Assignees
@lalexgap
Labels
🇵🇹 Lisbon Tasks and issues we should attempt to resolve before we go to Lisbon

Comments

@lalexgap
Copy link
Contributor

lalexgap commented Oct 7, 2022

Here is an example. It's possible that I just wan't patient enough (I manually killed the testground run).

However it may the change in this PR to recreate the subscription periodically. We may be missing an event during the period of unsubbing and resubbing.
@lalexgap lalexgap self-assigned this Oct 7, 2022
@lalexgap lalexgap added the 🇵🇹 Lisbon Tasks and issues we should attempt to resolve before we go to Lisbon label Oct 7, 2022
@lalexgap
Copy link
Contributor Author

lalexgap commented Nov 8, 2022

I think this has been resolved by a myriad of changes since this was opened. We're no longer seeing this behaviour.

@lalexgap lalexgap closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lalexgap lalexgap

Labels
🇵🇹 Lisbon Tasks and issues we should attempt to resolve before we go to Lisbon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lalexgap