Inject and mock yaml dumper (#3164)

Author: jasonvarga

src/Yaml/Yaml.php

@@ -13,6 +13,12 @@
 class Yaml
 {
     protected $file;
+    protected $yaml;
+
+    public function __construct(SymfonyYaml $yaml)
+    {
+        $this->yaml = $yaml;
+    }
 
     public function file($file)
     {
@@ -51,7 +57,7 @@ public function parse($str = null)
         }
 
         try {
-            $yaml = SymfonyYaml::parse($str);
+            $yaml = $this->yaml->parse($str);
         } catch (\Exception $e) {
             throw $this->viewException($e, $str);
         }
@@ -81,7 +87,7 @@ public function dump($data, $content = null)
             $data['content'] = $content;
         }
 
-        return SymfonyYaml::dump($data, 100, 2, SymfonyYaml::DUMP_MULTI_LINE_LITERAL_BLOCK);
+        return $this->yaml->dump($data, 100, 2, SymfonyYaml::DUMP_MULTI_LINE_LITERAL_BLOCK);
     }
 
     /**

tests/Yaml/YamlTest.php

@@ -5,6 +5,8 @@
 use Exception;
 use Statamic\Facades\YAML;
 use Statamic\Yaml\ParseException;
+use Statamic\Yaml\Yaml as StatamicYaml;
+use Symfony\Component\Yaml\Yaml as SymfonyYaml;
 use Tests\TestCase;
 
 class YamlTest extends TestCase
@@ -19,19 +21,16 @@ public function it_dumps_yaml()
             'array' => ['one', 'two'],
         ];
 
-        $expected = <<<'EOT'
-foo: bar
-two_words: 'two words'
-multiline: |
-  first
-  second
-array:
-  - one
-  - two
+        $symfonyYaml = $this->mock(SymfonyYaml::class)
+            ->shouldReceive('dump')
+            ->with($array, 100, 2, SymfonyYaml::DUMP_MULTI_LINE_LITERAL_BLOCK)
+            ->once()
+            ->andReturn('some properly dumped yaml from symfony')
+            ->getMock();
 
-EOT;
+        $this->app->instance(StatamicYaml::class, new StatamicYaml($symfonyYaml));
 
-        $this->assertEqualsIgnoringLineEndings($expected, YAML::dump($array));
+        $this->assertEquals('some properly dumped yaml from symfony', YAML::dump($array));
     }
 
     /** @test */