Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video filters and transforms #826

Conversation

JoeSmithStarkers
Copy link
Contributor

WIP in progress for review.

I've added css/svg based video filters to the scene player.

The video filters don't work across all browsers. Chrome is the closest to being fully functional, however an issue occurs when mixing an svg filter with a scale/rotate transformation. Firefox on the other hand is laggy with most filters and a decent sized video.

videoFilters

@JoeSmithStarkers JoeSmithStarkers force-pushed the feature/video_filters_and_transforms branch 8 times, most recently from 311b043 to c021721 Compare October 4, 2020 19:38
@WithoutPants
Copy link
Collaborator

While I can't see using this myself, this does cool, and works well based on my cursory tests on Chrome, Firefox and Edge. Haven't yet tried on the iPad. I do think that the Filters tab should probably not be the last tab, since that's the customary location for the Edit tab. The addition of this tab also overflows the tab container when the scene has Movies or a Gallery.

@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Oct 8, 2020
@JoeSmithStarkers JoeSmithStarkers force-pushed the feature/video_filters_and_transforms branch 2 times, most recently from 4b89d90 to edd6b58 Compare October 10, 2020 04:29
@JoeSmithStarkers
Copy link
Contributor Author

I've re-ordered the panels, and added an aspect ratio correction slider.

Still have to consider the issue of the overflow.

@JoeSmithStarkers
Copy link
Contributor Author

Any suggestions on handling the overflow?

@WithoutPants
Copy link
Collaborator

            <ButtonGroup className="ml-auto">
              <Nav.Item>
                <OCounterButton
                  loading={oLoading}
                  value={scene.o_counter || 0}
                  onIncrement={onIncrementClick}
                  onDecrement={onDecrementClick}
                  onReset={onResetClick}
                />
              </Nav.Item>
              <Nav.Item>{renderOperations()}</Nav.Item>
            </ButtonGroup>

This will make it so that the overflow menu and the O-Counter button break together to the next line if needed. That's good enough for me.

@WithoutPants WithoutPants added this to the Version 0.4.0 milestone Oct 12, 2020
@JoeSmithStarkers JoeSmithStarkers force-pushed the feature/video_filters_and_transforms branch from edd6b58 to e2e1b18 Compare October 12, 2020 23:14
…ure/video_filters_and_transforms

Fix conflicting imports of react-boostrap.

Conflicts:
	ui/v2.5/src/components/Scenes/SceneDetails/Scene.tsx
@WithoutPants WithoutPants merged commit 2987b7f into stashapp:develop Oct 22, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
@JoeSmithStarkers JoeSmithStarkers deleted the feature/video_filters_and_transforms branch November 8, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants