Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Scene Duplicate Checker report #5412

Open
David-Maisonave opened this issue Oct 23, 2024 · 0 comments
Open

[Feature] Scene Duplicate Checker report #5412

David-Maisonave opened this issue Oct 23, 2024 · 0 comments

Comments

@David-Maisonave
Copy link

David-Maisonave commented Oct 23, 2024

Improvements on Scene Duplicate Checker Report

The plugin DupFileManager also creates a report similar to Scene Duplicate Checker, but I do think the structure of the report is better with Scene Duplicate Checker, however there are a few things I wish it had that is in the DupFileManager report.

Existing options in DupFileManager report, recommend adding to Scene Duplicate Checker

  1. Add target="_blank" to the scene links, so user doesn't get kicked out of the report when clicking the scene link.
  2. Javascript driven option to disable the delete confirmation popup. For example code see field htmlReportPrefix in DupFileManager_config.py. Specifically do keyword search for RemoveToKeepConfirm. This can also be a URL parameter option.
    DupFileManagerJavascriptOptions
  3. Add Frame-Rate column to the report.
  4. Highlight or make text bold for fields which have different values from the other duplicates.
  5. If resolution is different, highlight the resolution field for duplicate with the highest resolution.
  6. If duration is different (3 or more seconds), highlight the resolution field for duplicate with the highest resolution.
  7. Merge tags (only) option.
  8. Option to display video preview instead of the tinny square of screen shots. Both preview and screenshot are already available for each scene, and IMHO, it's easier to view. Example coding:
    f"<td><video width='160' height='120' controls poster=\"{DupFile['paths']['screenshot']}\"><source src=\"{DupFile['paths']['preview']}\" type=\"video/mp4\"></video>
  9. Option to open folder (explorer), and option to play video locally. The local file is already being displayed on the report, and it would be easy to just make it a link to open the file locally. Below is example of how DupFileManager is doing it using separate links instead.
    DupFileManagerItemDetailsOptions
def getPath(Scene, getParent = False):
    path = stash.asc2(Scene['files'][0]['path'])
    path = path.replace("'", "")
    path = path.replace("\\\\", "\\")
    if getParent:
        return pathlib.Path(path).resolve().parent
    return path

fileHtmlReport.write(f"<a class=\"link-items\" title=\"Open folder\" href=\"file://{getPath(DupFile, True)}\">[Folder]</a>")
fileHtmlReport.write(f"<a class=\"link-items\" title=\"Play file locally\" href=\"file://{getPath(DupFile)}\">[Play]</a>")
  1. Option to add exclusion tag to the scene, which would allow file from being included in the report in the future.
  2. Add title field to the "Merge" button, which explicitly states what is being merge. In HTML the content of the title field creates a popup window when user hovers over the button.
    On related question, what exactly is being merge when there's a group of 3 or more duplicates and the user clicks the merge button?
  3. Maximum Duration Difference option using percentage. Leave the static seconds (1, 5, 10), but also add a 95%, 90% and 85% option.

All the above options are already in the DupFileManager report. Here are some options which I plan to add, which I would like to see in the Scene Duplicate Checker Report.

  1. Copy file option. For Scene Duplicate Checker, this option should only be displayed on scenes with 2 duplicates, which are by far the majority of duplicates in most reports.
  2. Add the following options to the bottom of the report:
    • Option to run PHASH generation task.
    • Option to delete all duplicates in specified folders (paths). Use a form to allow user to enter path.
    • Option to add specified tag to all duplicates. (This logic already exist in DupFileManager by default.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant