Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] UI Plugin dependency loading #4241

Closed
feederbox826 opened this issue Oct 25, 2023 · 2 comments · Fixed by #4260
Closed

[Feature] UI Plugin dependency loading #4241

feederbox826 opened this issue Oct 25, 2023 · 2 comments · Fixed by #4260

Comments

@feederbox826
Copy link
Contributor

feederbox826 commented Oct 25, 2023

Is your feature request related to a problem? Please describe.
no

Describe the solution you'd like
In replacing userscripts with ui plugins, script libraries and CSS imports have to be downloaded alongside plugins and injected into the /javascript and /css files

alongside CSP allowed domains, additional properties for imported scripts (corresponding to CSP: script-src) and imported stylesheets (CSP:style-src) can be added, and injected as <style> and <script> blocks

Describe alternatives you've considered
Currently the files are being downloaded unminfied and stored in the plugin's repo but this leaves room for malicious actors uploading minified, modified code.

Additional context
Originally discussed in Userscript -> JS plugin port thread on discord
original CSP PR #2108

@feederbox826 feederbox826 changed the title [Feature] UI Plugin depdency loading [Feature] UI Plugin dependency loading Oct 26, 2023
@feederbox826
Copy link
Contributor Author

closed in #4256

@DogmaDragon
Copy link
Collaborator

I'm pretty sure it was addressed in #4260.

@DogmaDragon DogmaDragon linked a pull request May 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants