Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add option to Generate thumbnails for image files #4189

Closed
JoeShymoe opened this issue Oct 10, 2023 · 10 comments · Fixed by #4602
Closed

[Feature] Add option to Generate thumbnails for image files #4189

JoeShymoe opened this issue Oct 10, 2023 · 10 comments · Fixed by #4602

Comments

@JoeShymoe
Copy link

Is your feature request related to a problem? Please describe.
Currently it is not possible to change image thumbnails after they are initially scanned.

Describe the solution you'd like
Stash has options under the Generate heading to do similar things for a number of other options. It would be useful if image thumbnails was added to that list.

Describe alternatives you've considered
Delete the images from stash and rescan them.

@xantror
Copy link

xantror commented Oct 10, 2023

Implementing this will also help people who did not choose to generate image thumbnails during scan but do want to generate them later.

Currently, when they are generated during a scan, it respects the Number of parallel task for scan/generation setting.

When they are generated automatically while browsing, stash currently tries to generate thumbnails for all images on the page at the same time, which might lead to stash crashing due to OOM when there are many large images (I've had stash crash due to this).

@Dark-Obsidian
Copy link

+1

From the above, I am taking it that stash doesn't generate a new thumbnail when it detects an ohash change (i.e. the image has changed)?... If not then yes, this would be good to add.

@elshanta
Copy link

I have the same issue here. I scanned thousands of image galleries without Generate previews for image clips option and now it is imposible to rescan them to generate missing image thumbnails:

Captura de Pantalla 2023-10-20 a la(s) 12 58 00

@Ksrx01
Copy link
Contributor

Ksrx01 commented Oct 22, 2023

might lead to stash crashing due to OOM when there are many large images.

Well this explains a lot. I'm currently experiencing the same issue.

@elshanta
Copy link

Please consider both folder galleries and zip galleries 🙏

@DogmaDragon
Copy link
Collaborator

@elshanta please make a separate issue. Tailored issues allow for faster development.

@Ksrx01
Copy link
Contributor

Ksrx01 commented Oct 23, 2023

Please consider both folder galleries and zip galleries 🙏

Kinda OT and I don't want to sound presumptuous, but I switched a rather extensive library from folder to zips.
If you don't access those folders by means other than Stash, it has a number of advantages that shouldn't be discarded, especially from a storage point of view.

@elshanta
Copy link

Please consider both folder galleries and zip galleries 🙏

Kinda OT and I don't want to sound presumptuous, but I switched a rather extensive library from folder to zips. If you don't access those folders by means other than Stash, it has a number of advantages that shouldn't be discarded, especially from a storage point of view.

thanks for the recommendation.

@elshanta
Copy link

Any kind soul who can start this on the backlog please 🙏 Should be a quick fix.

@elshanta
Copy link

This was partially solved but there are still some cases where galleries have empty thumbnails.
Captura de pantalla 2024-06-22 a la(s) 15 38 47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants