Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Display embedded subtitles #3875

Open
cmcglownjr opened this issue Jul 2, 2023 · 4 comments
Open

[Feature] Display embedded subtitles #3875

cmcglownjr opened this issue Jul 2, 2023 · 4 comments
Labels
bounty This issue has a bounty on it in the OpenCollective feature request

Comments

@cmcglownjr
Copy link

Is your feature request related to a problem? Please describe.
Currently mkv files that have subtitles embedded will not display those subtitles.

Describe the solution you'd like
Stash can display external captions but it should also be able to display embedded captions. Most desktop and mobile media players can display embedded captions so if possible can embedded captions be displayed in the Stash video player.

@7x5rg
Copy link

7x5rg commented Oct 22, 2023

+1

1 similar comment
@LewdCollector
Copy link

+1

@WithoutPants
Copy link
Collaborator

Videojs does not support displaying embedded subtitles.

There's a few possible ways that I can think of to display subtitles on the fly:

  • have ffmpeg live transcode and embed the subtitles. This adds overhead that would be undesirable
  • enable on-the-fly generation of subtitles. This is fast, but requires a bit of preparatory work before-hand and will need to be cached.

This improvement should be considered alongside the other caption bug-fixing/improvements (see #2619 and #3800).

In the meantime, this could probably be addressed with a plugin to generate srt files from files with embedded subs.

@WithoutPants
Copy link
Collaborator

$50 bounty assigned (contribution 745825)

@WithoutPants WithoutPants added the bounty This issue has a bounty on it in the OpenCollective label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty This issue has a bounty on it in the OpenCollective feature request
Projects
Status: No status
Development

No branches or pull requests

4 participants