Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Performers are not matched by alias when scraping / identifying #3423

Closed
puc9 opened this issue Feb 12, 2023 · 2 comments · Fixed by #4182
Closed

[Bug Report] Performers are not matched by alias when scraping / identifying #3423

puc9 opened this issue Feb 12, 2023 · 2 comments · Fixed by #4182
Labels
bug report Bug reports that are not yet verified

Comments

@puc9
Copy link
Contributor

puc9 commented Feb 12, 2023

Describe the bug
When scraping manually or running identify if a performer name is returned that matches an alias but not a performer then a new performer is created

To Reproduce
Steps to reproduce the behavior:
Any scraping but especially from LP since they use a lot of names that are aliased in stashbox.

Expected behavior
A match should be done by performer name and if not found then by performer alias.
Clarifying what should happen when finding multiple matches is technically outside the scope of this bug but a few ideas:

  • pick the first match
  • add all matches and also a tag (BTW we need a separate set of tags like system tags or library management tags) so that the scene can be manually fixed afterwards. Organized should not be set in this scenario

Stash Version: (from Settings -> About):
Latest develop built locally

Additional context
I have tried to fix this myself but for the life of me I can't figure out where that matching happens. If someone knows and can point me to the code I can attempt a fix.

@puc9 puc9 added the bug report Bug reports that are not yet verified label Feb 12, 2023
@gaytomi
Copy link

gaytomi commented Feb 24, 2023

This seems like a big issue - what's the point of aliases if they don't tag to videos?

@WithoutPants WithoutPants added this to the Backlog milestone Mar 14, 2023
@Flashy78
Copy link
Contributor

Flashy78 commented Oct 8, 2023

Scene tagger can now look for exact alias matching with #4182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug reports that are not yet verified
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants