Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Scrolling Volume and Seek control behaviour on the video player #2221

Open
anteac opened this issue Jan 8, 2022 · 2 comments
Open
Labels
feature Pull requests that add a new feature ui Issues related to UI

Comments

@anteac
Copy link

anteac commented Jan 8, 2022

Im very used to pornganizer's way of scrolling anywhere on the left half of the video player to adjust volume up/down, and right half of the video to seek forward/backward.

This should be pretty easy to implement using JWplayer's api and a event handler for scroll events on the visible player.

Suggest adding a setting to enable and disable this behaviour somewhere and having it disabled by default since its pretty unexpected behaviour if your not used to it.

I don't think it'll work on mobile or not very intuitive anyway so probably best to just not include the scroll event code at all on mobile devices

Issue #2206 is basicly the same but for the grid view.

Also would like having middle click (scroll wheel click) to toggle fullscreen, but not sure what other's opinion about that is or if you even want that, can be annoying sometimes if you scroll too hard

@anteac
Copy link
Author

anteac commented Jan 8, 2022

VideoJS and JWPlayer both support controlling volume and seeking via js api so this feature shouldn't cause issues when you switch to videojs

@kermieisinthehouse kermieisinthehouse added feature Pull requests that add a new feature ui Issues related to UI labels Jan 8, 2022
@anteac
Copy link
Author

anteac commented Jan 8, 2022

https://github.com/ctd1500/videojs-hotkeys/blob/master/example.html
might be helpful, pretty much provides the volume scroll control behaviour already that I mean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature ui Issues related to UI
Projects
None yet
Development

No branches or pull requests

2 participants