From aa8bfaf40799135828af470cee46df9eb8ac4b4c Mon Sep 17 00:00:00 2001 From: Leopere <1068374+Leopere@users.noreply.github.com> Date: Wed, 12 Feb 2020 21:07:51 -0500 Subject: [PATCH] [Feature] Adding Feature.md/BugFix.md Pull Request Template. (#343) * Adding Feature.md Pull Request Template. * Create BugFix.md Pull Request Tempalte * Create CONTRIBUTING.md * Disabled Librepay since we've decided properly on OpenCollective --- .github/FUNDING.yml | 2 +- .github/PULL_REQUEST_TEMPLATE/BugFix.md | 18 ++++++++++++++++++ .github/PULL_REQUEST_TEMPLATE/Feature.md | 17 +++++++++++++++++ docs/CONTRIBUTING.md | 14 ++++++++++++++ 4 files changed, 50 insertions(+), 1 deletion(-) create mode 100644 .github/PULL_REQUEST_TEMPLATE/BugFix.md create mode 100644 .github/PULL_REQUEST_TEMPLATE/Feature.md create mode 100644 docs/CONTRIBUTING.md diff --git a/.github/FUNDING.yml b/.github/FUNDING.yml index 273b0c5a89b..f794f093632 100644 --- a/.github/FUNDING.yml +++ b/.github/FUNDING.yml @@ -6,7 +6,7 @@ open_collective: stashapp # ko_fi: # Replace with a single Ko-fi username # tidelift: # Replace with a single Tidelift platform-name/package-name e.g., npm/babel # community_bridge: # Replace with a single Community Bridge project-name e.g., cloud-foundry -liberapay: StashApp +# liberapay: StashApp # issuehunt: # Replace with a single IssueHunt username # otechie: # Replace with a single Otechie username # custom: # Replace with up to 4 custom sponsorship URLs e.g., ['link1', 'link2'] diff --git a/.github/PULL_REQUEST_TEMPLATE/BugFix.md b/.github/PULL_REQUEST_TEMPLATE/BugFix.md new file mode 100644 index 00000000000..3ad41f74ec1 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/BugFix.md @@ -0,0 +1,18 @@ +--- +name: Bug Fix +about: Add a bug fix this project! +title: "[Bug Fix] Short Form Title (50 chars or less.)" +labels: bug +assignees: 'WithoutPants, bnkai, Leopere' + +--- + + +# Scope + + +## Closes/Fixes Issues + + +## Other testing QA Notes + diff --git a/.github/PULL_REQUEST_TEMPLATE/Feature.md b/.github/PULL_REQUEST_TEMPLATE/Feature.md new file mode 100644 index 00000000000..39abce19b5e --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE/Feature.md @@ -0,0 +1,17 @@ +--- +name: Feature Addition +about: Add a feature to this project! +title: "[Feature] Short Form Title (50 chars or less.)" +labels: enhancement +assignees: 'WithoutPants, bnkai, Leopere' + +--- + +# Scope + + +## Closes/Fixes Issues + + +## Other testing QA Notes diff --git a/docs/CONTRIBUTING.md b/docs/CONTRIBUTING.md new file mode 100644 index 00000000000..faf956d8f2b --- /dev/null +++ b/docs/CONTRIBUTING.md @@ -0,0 +1,14 @@ + +## Technical Debt +Please be sure to consider how heavily your contribution impacts the maintainability of the project long term, sometimes less is more. We don't want to merge collossal pull requests with hundreds of dependencies by a driveby contributor. + +## Contributor Checklist +Please make sure that you've considered the following before you submit your Pull Requests as ready for merging. +* I've run Code linters and [gofmt](https://golang.org/cmd/gofmt/) to make sure that my code is readable. +* I have read through formerly submitted [pull requests](https://github.com/stashapp/stash/pulls) and [git issues](https://github.com/stashapp/stash/issues) to make sure that this contribution is required and isn't a duplicate. Also, so that I can manage to close any git Issues needing closed relating to this feature submission. +* I commented adequately on my code with the expectation in mind that anyone else should be able to look at this code I've submitted and know exactly what's happening and what the expectations are. + +### Legal Agreements +* I acknowledge that if applicable to me, submitting and subsequent acceptance of this Pull Request I, the code contributor of this Pull Request, agree and acknowledge my understanding that the new code license has now been updated to [AGPL](/LICENSE.md). I agree that all code before this Pull Request, which I've previously submitted, is now to be re-licensed under the new license AGPL and no longer the former MIT license. + +**In case you were unable to follow any of the above include an explanation as to why not in your Pull Request.**