From 1e59c4054ab51f54caf7d87bb54c3a4bd87a03ff Mon Sep 17 00:00:00 2001
From: Mingyu Chen <morningman.cmy@gmail.com>
Date: Wed, 3 Aug 2022 08:43:14 +0800
Subject: [PATCH] [minor](log) add some log to observe the change of table's
 state. (#11448)

When upgrading to 1.x, some table's state may change to ROLLUP,
Resulting in not able to create/drop/modify partition.

I haven't find the root cause yet, so I add some log to observe
the change of table's state.
---
 .../apache/doris/alter/MaterializedViewHandler.java  | 12 ++++++++++++
 .../org/apache/doris/alter/SchemaChangeJobV2.java    |  1 +
 2 files changed, 13 insertions(+)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java b/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
index 35fe2834008da6..39447a307e2db4 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
@@ -909,8 +909,15 @@ public void replayAlterJobV2(AlterJobV2 alterJob) {
         if (!alterJob.isDone()) {
             addAlterJobV2ToTableNotFinalStateJobMap(alterJob);
             changeTableStatus(alterJob.getDbId(), alterJob.getTableId(), OlapTableState.ROLLUP);
+            LOG.info("set table's state to ROLLUP, table id: {}, job id: {}", alterJob.getTableId(),
+                    alterJob.getJobId());
         } else if (removeAlterJobV2FromTableNotFinalStateJobMap(alterJob)) {
             changeTableStatus(alterJob.getDbId(), alterJob.getTableId(), OlapTableState.NORMAL);
+            LOG.info("set table's state to NORMAL, table id: {}, job id: {}", alterJob.getTableId(),
+                    alterJob.getJobId());
+        } else {
+            LOG.info("not set table's state, table id: {}, is job done: {}, job id: {}", alterJob.getTableId(),
+                    alterJob.isDone(), alterJob.getJobId());
         }
     }
 
@@ -983,6 +990,11 @@ private void onJobDone(AlterJobV2 alterJob) {
         removeJobFromRunningQueue(alterJob);
         if (removeAlterJobV2FromTableNotFinalStateJobMap(alterJob)) {
             changeTableStatus(alterJob.getDbId(), alterJob.getTableId(), OlapTableState.NORMAL);
+            LOG.info("set table's state to NORMAL, table id: {}, job id: {}", alterJob.getTableId(),
+                    alterJob.getJobId());
+        } else {
+            LOG.info("not set table's state, table id: {}, is job done: {}, job id: {}", alterJob.getTableId(),
+                    alterJob.isDone(), alterJob.getJobId());
         }
     }
 
diff --git a/fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java b/fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java
index 7320f9db90dfb9..062b3b5e2791fd 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeJobV2.java
@@ -709,6 +709,7 @@ private void cancelInternal() {
                         tbl.deleteIndexInfo(shadowIndexName);
                     }
                     tbl.setState(OlapTableState.NORMAL);
+                    LOG.info("set table's state to NORMAL when cancel job: {}", tbl.getId(), jobId);
                 } finally {
                     tbl.writeUnlock();
                 }