chore(starknet_sequencer_node): remove redundant port allocation

Author: Itay-Tsabary-Starkware

crates/starknet_integration_tests/src/node_component_configs.rs

@@ -217,7 +217,6 @@ pub fn create_nodes_deployment_units_configs(
         let class_manager_socket = available_ports.get_next_local_host_socket();
         let gateway_socket = available_ports.get_next_local_host_socket();
         let mempool_socket = available_ports.get_next_local_host_socket();
-        let mempool_p2p_socket = available_ports.get_next_local_host_socket();
         let sierra_compiler_socket = available_ports.get_next_local_host_socket();
         let state_sync_socket = available_ports.get_next_local_host_socket();
         let l1_provider_socket = available_ports.get_next_local_host_socket();
@@ -242,11 +241,6 @@ pub fn create_nodes_deployment_units_configs(
             mempool_socket.ip(),
             mempool_socket.port(),
         );
-        let mempool_p2p_remote_config_pair = DistributedNodeServiceConfigPair::new(
-            Ipv4Addr::LOCALHOST.to_string(),
-            mempool_p2p_socket.ip(),
-            mempool_p2p_socket.port(),
-        );
         let sierra_compiler_remote_config_pair = DistributedNodeServiceConfigPair::new(
             Ipv4Addr::LOCALHOST.to_string(),
             sierra_compiler_socket.ip(),
@@ -283,7 +277,6 @@ pub fn create_nodes_deployment_units_configs(
                 ),
                 get_mempool_config(
                     mempool_remote_config_pair.local(),
-                    mempool_p2p_remote_config_pair.local(),
                     class_manager_remote_config_pair.remote(),
                     gateway_remote_config_pair.remote(),
                 ),

crates/starknet_sequencer_node/src/deployment.rs

@@ -274,7 +274,7 @@ impl DistributedNodeServiceName {
     // TODO(Tsabary): consider alternatives that enable removing the linter suppression.
     #[allow(clippy::as_conversions)]
     fn get_port_offset(&self) -> u16 {
-        self.clone() as u16
+        *self as u16
     }
 }
 
@@ -362,13 +362,12 @@ pub fn get_gateway_config(
 
 pub fn get_mempool_config(
     mempool_local_config: ReactiveComponentExecutionConfig,
-    mempool_p2p_local_config: ReactiveComponentExecutionConfig,
     class_manager_remote_config: ReactiveComponentExecutionConfig,
     gateway_remote_config: ReactiveComponentExecutionConfig,
 ) -> ComponentConfig {
     let mut config = ComponentConfig::disabled();
     config.mempool = mempool_local_config;
-    config.mempool_p2p = mempool_p2p_local_config;
+    config.mempool_p2p = ReactiveComponentExecutionConfig::local_with_remote_disabled();
     config.class_manager = class_manager_remote_config;
     config.gateway = gateway_remote_config;
     config.monitoring_endpoint = ActiveComponentExecutionConfig::enabled();