toHextruncates leading zeroes

[naorye]

toHex function truncates leading zeroes:

starknet.js/src/utils/num.ts

Line 36 in 70e7ba6

export function toHex(number: BigNumberish): string {

For example:

toHex('0x023A2aAc5d0fa69E3243994672822BA43E34E5C9') // === "0x23A2aAc5d0fa69E3243994672822BA43E34E5C9"

(zero after '0x' gets truncate)

[PhilippeR26]

Hello,
Seems to be a normal behavior...
If you want a leading 0 (if necessary) :

const hexNum = encode.sanitizeHex(hexString);

[tabaktoni]

In general, toHex is an unopinionated number conversion.

Maybe we should add a helper method

 toCallerAddress(number: BigNumberish): string;

That would ensure leading zero on every conversion based on https://docs.starknet.io/documentation/architecture_and_concepts/Network_Architecture/starknet-state/#address_0x0

[PhilippeR26]

Just use addAddressPadding(address: BigNumberish): string

[ivpavici]

We have 3 options:

1. add additional explanations to the guides about this case
2. implement Toni's suggestion
3. do both :D

[PhilippeR26]

This function is already existing in Starknet.js : https://www.starknetjs.com/docs/next/api/modules/#addaddresspadding

If you want, I can add some JSdoc.

[ivpavici]

ok, we can do that also! thanks!

[PhilippeR26]

Made.

[naorye]

@PhilippeR26 @ivpavici @tabaktoni

Sorry, I didn't explain the actual issue.

The following method

starknet.js/src/provider/rpc.ts

Line 675 in d72b1be

from_address: toHex(from_address),

uses toHex in order to make sure address is hex. By doing so padding zeroes are getting removed and the RPC throws an exception about incorrect address length.

[PhilippeR26]

This time I understood.
The node is expecting a string representing an hex number coded with 20 bytes.
I will have a look.
@ivpavici , could you assign me?