Skip to content

Commit

Permalink
x86/irq: Remove unused vectors defines
Browse files Browse the repository at this point in the history
UV_BAU_MESSAGE is defined but not used anywhere in the kernel. Presumably
this is a stale vector number that can be reclaimed.

MCE_VECTOR is not an actual vector: #MC is an exception, not an interrupt
vector, and as such is correctly described as X86_TRAP_MC. MCE_VECTOR is
not used anywhere is the kernel.

Note that NMI_VECTOR *is* used; specifically it is the vector number
programmed into the APIC LVT when an NMI interrupt is configured. At
the moment it is always numerically identical to X86_TRAP_NMI, that is
not necessarily going to be the case indefinitely.

Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Steve Wahl <steve.wahl@hpe.com>
Link: https://lore.kernel.org/r/20210519212154.511983-4-hpa@zytor.com
  • Loading branch information
H. Peter Anvin (Intel) authored and KAGA-KOKO committed May 21, 2021
1 parent d07f6ca commit f1b7d45
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions arch/x86/include/asm/irq_vectors.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
* This file enumerates the exact layout of them:
*/

/* This is used as an interrupt vector when programming the APIC. */
#define NMI_VECTOR 0x02
#define MCE_VECTOR 0x12

/*
* IDT vectors usable for external interrupt sources start at 0x20.
Expand Down Expand Up @@ -84,7 +84,7 @@
*/
#define IRQ_WORK_VECTOR 0xf6

#define UV_BAU_MESSAGE 0xf5
/* 0xf5 - unused, was UV_BAU_MESSAGE */
#define DEFERRED_ERROR_VECTOR 0xf4

/* Vector on which hypervisor callbacks will be delivered */
Expand Down
4 changes: 2 additions & 2 deletions tools/arch/x86/include/asm/irq_vectors.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
* This file enumerates the exact layout of them:
*/

/* This is used as an interrupt vector when programming the APIC. */
#define NMI_VECTOR 0x02
#define MCE_VECTOR 0x12

/*
* IDT vectors usable for external interrupt sources start at 0x20.
Expand Down Expand Up @@ -84,7 +84,7 @@
*/
#define IRQ_WORK_VECTOR 0xf6

#define UV_BAU_MESSAGE 0xf5
/* 0xf5 - unused, was UV_BAU_MESSAGE */
#define DEFERRED_ERROR_VECTOR 0xf4

/* Vector on which hypervisor callbacks will be delivered */
Expand Down

0 comments on commit f1b7d45

Please sign in to comment.