Skip to content

Commit f1b7d45

Browse files
H. Peter Anvin (Intel)KAGA-KOKO
authored andcommitted
x86/irq: Remove unused vectors defines
UV_BAU_MESSAGE is defined but not used anywhere in the kernel. Presumably this is a stale vector number that can be reclaimed. MCE_VECTOR is not an actual vector: #MC is an exception, not an interrupt vector, and as such is correctly described as X86_TRAP_MC. MCE_VECTOR is not used anywhere is the kernel. Note that NMI_VECTOR *is* used; specifically it is the vector number programmed into the APIC LVT when an NMI interrupt is configured. At the moment it is always numerically identical to X86_TRAP_NMI, that is not necessarily going to be the case indefinitely. Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Steve Wahl <steve.wahl@hpe.com> Link: https://lore.kernel.org/r/20210519212154.511983-4-hpa@zytor.com
1 parent d07f6ca commit f1b7d45

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

arch/x86/include/asm/irq_vectors.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
* This file enumerates the exact layout of them:
2727
*/
2828

29+
/* This is used as an interrupt vector when programming the APIC. */
2930
#define NMI_VECTOR 0x02
30-
#define MCE_VECTOR 0x12
3131

3232
/*
3333
* IDT vectors usable for external interrupt sources start at 0x20.
@@ -84,7 +84,7 @@
8484
*/
8585
#define IRQ_WORK_VECTOR 0xf6
8686

87-
#define UV_BAU_MESSAGE 0xf5
87+
/* 0xf5 - unused, was UV_BAU_MESSAGE */
8888
#define DEFERRED_ERROR_VECTOR 0xf4
8989

9090
/* Vector on which hypervisor callbacks will be delivered */

tools/arch/x86/include/asm/irq_vectors.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@
2626
* This file enumerates the exact layout of them:
2727
*/
2828

29+
/* This is used as an interrupt vector when programming the APIC. */
2930
#define NMI_VECTOR 0x02
30-
#define MCE_VECTOR 0x12
3131

3232
/*
3333
* IDT vectors usable for external interrupt sources start at 0x20.
@@ -84,7 +84,7 @@
8484
*/
8585
#define IRQ_WORK_VECTOR 0xf6
8686

87-
#define UV_BAU_MESSAGE 0xf5
87+
/* 0xf5 - unused, was UV_BAU_MESSAGE */
8888
#define DEFERRED_ERROR_VECTOR 0xf4
8989

9090
/* Vector on which hypervisor callbacks will be delivered */

0 commit comments

Comments
 (0)