ipv4: Correct/silence an endian warning in __ip_do_redirect

KunWuChan · Paolo Abeni · commit c0e2926266af · 2023-11-21T12:55:22.000+01:00
net/ipv4/route.c:783:46: warning: incorrect type in argument 2 (different base types) net/ipv4/route.c:783:46: expected unsigned int [usertype] key net/ipv4/route.c:783:46: got restricted __be32 [usertype] new_gw Fixes: 969447f ("ipv4: use new_gw for redirect neigh lookup") Suggested-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Kunwu Chan <chentao@kylinos.cn> Link: https://lore.kernel.org/r/20231119141759.420477-1-chentao@kylinos.cn Signed-off-by: Paolo Abeni <pabeni@redhat.com>
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
@@ -780,7 +780,7 @@ static void __ip_do_redirect(struct rtable *rt, struct sk_buff *skb, struct flow
 			goto reject_redirect;
 	}
 
-	n = __ipv4_neigh_lookup(rt->dst.dev, new_gw);
+	n = __ipv4_neigh_lookup(rt->dst.dev, (__force u32)new_gw);
 	if (!n)
 		n = neigh_create(&arp_tbl, &new_gw, rt->dst.dev);
 	if (!IS_ERR(n)) {

Original file line number	Diff line number	Diff line change
`@@ -780,7 +780,7 @@ static void __ip_do_redirect(struct rtable rt, struct sk_buff skb, struct flow`
`780`	`780`	`goto reject_redirect;`
`781`	`781`	`}`
`782`	`782`
`783`		`- n = __ipv4_neigh_lookup(rt->dst.dev, new_gw);`
	`783`	`+ n = __ipv4_neigh_lookup(rt->dst.dev, (__force u32)new_gw);`
`784`	`784`	`if (!n)`
`785`	`785`	`n = neigh_create(&arp_tbl, &new_gw, rt->dst.dev);`
`786`	`786`	`if (!IS_ERR(n)) {`