Skip to content

Commit 68f6783

Browse files
KAGA-KOKOjohnstultz-work
authored andcommitted
delayacct: Remove braindamaged type conversions
Converting cputime to timespec and timespec to nanoseconds makes no sense. Use cputime_to_ns() and be done with it. Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Signed-off-by: John Stultz <john.stultz@linaro.org>
1 parent 9667a23 commit 68f6783

File tree

1 file changed

+7
-11
lines changed

1 file changed

+7
-11
lines changed

kernel/delayacct.c

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -82,23 +82,19 @@ void __delayacct_blkio_end(void)
8282

8383
int __delayacct_add_tsk(struct taskstats *d, struct task_struct *tsk)
8484
{
85-
s64 tmp;
86-
unsigned long t1;
87-
unsigned long long t2, t3;
88-
unsigned long flags;
89-
struct timespec ts;
9085
cputime_t utime, stime, stimescaled, utimescaled;
86+
unsigned long long t2, t3;
87+
unsigned long flags, t1;
88+
s64 tmp;
9189

92-
tmp = (s64)d->cpu_run_real_total;
9390
task_cputime(tsk, &utime, &stime);
94-
cputime_to_timespec(utime + stime, &ts);
95-
tmp += timespec_to_ns(&ts);
91+
tmp = (s64)d->cpu_run_real_total;
92+
tmp += cputime_to_nsecs(utime + stime);
9693
d->cpu_run_real_total = (tmp < (s64)d->cpu_run_real_total) ? 0 : tmp;
9794

98-
tmp = (s64)d->cpu_scaled_run_real_total;
9995
task_cputime_scaled(tsk, &utimescaled, &stimescaled);
100-
cputime_to_timespec(utimescaled + stimescaled, &ts);
101-
tmp += timespec_to_ns(&ts);
96+
tmp = (s64)d->cpu_scaled_run_real_total;
97+
tmp += cputime_to_nsecs(utimescaled + stimescaled);
10298
d->cpu_scaled_run_real_total =
10399
(tmp < (s64)d->cpu_scaled_run_real_total) ? 0 : tmp;
104100

0 commit comments

Comments
 (0)