Skip to content

Commit

Permalink
[NETLINK]: Ignore control messages directly in netlink_run_queue()
Browse files Browse the repository at this point in the history
Changes netlink_rcv_skb() to skip netlink controll messages and don't
pass them on to the message handler.

Signed-off-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
tgraf authored and David S. Miller committed Apr 26, 2007
1 parent d35b685 commit 45e7ae7
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 14 deletions.
4 changes: 0 additions & 4 deletions net/core/rtnetlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -864,10 +864,6 @@ rtnetlink_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh, int *errp)

type = nlh->nlmsg_type;

/* A control message: ignore them */
if (type < RTM_BASE)
return 0;

/* Unknown message: reply with EINVAL */
if (type > RTM_MAX)
goto err_inval;
Expand Down
4 changes: 4 additions & 0 deletions net/netlink/af_netlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -1479,6 +1479,10 @@ static int netlink_rcv_skb(struct sk_buff *skb, int (*cb)(struct sk_buff *,
if (!(nlh->nlmsg_flags & NLM_F_REQUEST))
goto skip;

/* Skip control messages */
if (nlh->nlmsg_type < NLMSG_MIN_TYPE)
goto skip;

if (cb(skb, nlh, &err) < 0) {
/* Not an error, but we have to interrupt processing
* here. Note: that in this case we do not pull
Expand Down
6 changes: 0 additions & 6 deletions net/netlink/genetlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -304,9 +304,6 @@ static int genl_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh,
struct genlmsghdr *hdr = nlmsg_data(nlh);
int hdrlen, err = -EINVAL;

if (nlh->nlmsg_type < NLMSG_MIN_TYPE)
goto ignore;

family = genl_family_find_byid(nlh->nlmsg_type);
if (family == NULL) {
err = -ENOENT;
Expand Down Expand Up @@ -364,9 +361,6 @@ static int genl_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh,
*errp = err = ops->doit(skb, &info);
return err;

ignore:
return 0;

errout:
*errp = err;
return -1;
Expand Down
4 changes: 0 additions & 4 deletions net/xfrm/xfrm_user.c
Original file line number Diff line number Diff line change
Expand Up @@ -1860,10 +1860,6 @@ static int xfrm_user_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh, int *err

type = nlh->nlmsg_type;

/* A control message: ignore them */
if (type < XFRM_MSG_BASE)
return 0;

/* Unknown message: reply with EINVAL */
if (type > XFRM_MSG_MAX)
goto err_einval;
Expand Down

0 comments on commit 45e7ae7

Please sign in to comment.