Skip to content

Commit

Permalink
latencytop: optimize LT_BACKTRACEDEPTH loops a bit
Browse files Browse the repository at this point in the history
There is no need to loop any longer when 'same == 0'.

Signed-off-by: Dmitry Adamushko <dmitry.adamushko@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
stablebits authored and Ingo Molnar committed Apr 19, 2008
1 parent 50df5d6 commit 19fb518
Showing 1 changed file with 17 additions and 10 deletions.
27 changes: 17 additions & 10 deletions kernel/latencytop.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,21 +64,24 @@ account_global_scheduler_latency(struct task_struct *tsk, struct latency_record
return;

for (i = 0; i < MAXLR; i++) {
int q;
int same = 1;
int q, same = 1;

/* Nothing stored: */
if (!latency_record[i].backtrace[0]) {
if (firstnonnull > i)
firstnonnull = i;
continue;
}
for (q = 0 ; q < LT_BACKTRACEDEPTH ; q++) {
if (latency_record[i].backtrace[q] !=
lat->backtrace[q])
unsigned long record = lat->backtrace[q];

if (latency_record[i].backtrace[q] != record) {
same = 0;
if (same && lat->backtrace[q] == 0)
break;
if (same && lat->backtrace[q] == ULONG_MAX)
}

/* 0 and ULONG_MAX entries mean end of backtrace: */
if (record == 0 || record == ULONG_MAX)
break;
}
if (same) {
Expand Down Expand Up @@ -143,14 +146,18 @@ account_scheduler_latency(struct task_struct *tsk, int usecs, int inter)
for (i = 0; i < LT_SAVECOUNT ; i++) {
struct latency_record *mylat;
int same = 1;

mylat = &tsk->latency_record[i];
for (q = 0 ; q < LT_BACKTRACEDEPTH ; q++) {
if (mylat->backtrace[q] !=
lat.backtrace[q])
unsigned long record = lat.backtrace[q];

if (mylat->backtrace[q] != record) {
same = 0;
if (same && lat.backtrace[q] == 0)
break;
if (same && lat.backtrace[q] == ULONG_MAX)
}

/* 0 and ULONG_MAX entries mean end of backtrace: */
if (record == 0 || record == ULONG_MAX)
break;
}
if (same) {
Expand Down

0 comments on commit 19fb518

Please sign in to comment.