Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running scheduler_tests.py #241

Open
nayakajay opened this issue May 23, 2022 · 3 comments
Open

Running scheduler_tests.py #241

nayakajay opened this issue May 23, 2022 · 3 comments

Comments

@nayakajay
Copy link

nayakajay commented May 23, 2022

I wanted to run the test scheduler_tests.py. I believe, for a given trace, this test will give me the schedule in a file /tmp/simple.output.

The traces used seems to be missing. I can use a different trace, but it does not have an "expected" output file for those. Also, the relevant file (run_scheduler_with_trace.py) is not prepared to take the arguments passed by the test.

@deepakn94
Copy link
Contributor

It looks like that test file is out-of-date :/
What arguments are not accepted by the driver?

@nayakajay
Copy link
Author

There are 3 arguments that are not supported.
--simulate
--worker_types
-l

The simulate argument can be handled as it can be read from command line and passed to the Scheduler's constructor. However, the other two are not expected arguments for the Scheduler class. I am not sure where they are to be passed or how to handle them.

@deepakn94
Copy link
Contributor

Actually, you want to use simulate_scheduler_with_trace.py: https://github.com/stanford-futuredata/gavel/blob/master/scheduler/scripts/drivers/simulate_scheduler_with_trace.py.

You can get rid of the --simulate argument then, simulate is set to True by default in this driver file. --worker_types is replaced by --cluster_spec. I'm not sure what -l did before, but you can probably omit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants