-
-
Notifications
You must be signed in to change notification settings - Fork 47
Add transformation information to --info #1462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
8fb1ed4
to
8d0c433
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1462 +/- ##
==========================================
- Coverage 89.60% 89.53% -0.08%
==========================================
Files 66 66
Lines 9707 9734 +27
==========================================
+ Hits 8698 8715 +17
- Misses 1009 1019 +10
🚀 New features to boost your workflow:
|
Would be easy to revisit if we wanted to, but doesn't seem like the original request went anywhere |
Hi Brian, was there a lack of support for this change? Let me know if I can help resurrect it. |
Hi Andrew -- after you closed #1461 it seemed like there wasn't a use case for this so I never requested a code review. If it's still useful we could reopen it for discussion |
I have workarounds, but this would be a much more elegant solution. I think having these tools to inspect a Stan model can only help algorithm developers. If it is more or less implemented (modulo review) I would for sure appreciate it if it could be reviewed and merged. But just my opinion :) |
"dimensions": 1, | ||
"constraint": "positive_ordered" | ||
}, | ||
"p": { "type": "real", "dimensions": 2, "constraint": "covariance" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of confused on the output format here. Is there a reason this is not "type": "matrix"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm frankly not sure, but that behavior has been the case since the flag was added in #810
My guess is that it let the output be non-recursive pre-tuples, because array[N] matrix[M,K]
just got collapsed to dimensions: 3
Can you have the tests show what this looks for more complex types like tuples or arrays of arrays of matrices etc? |
|
Closes #1461.
Bikeshedding: Should this new field be called
constraint
,transform
, or something else?Submission Checklist
Release notes
The
--info
flag will now also give information about the transformations of each variableCopyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)