Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor src/stan/gm/command.hpp: debugging is difficult as is. #405

Closed
3 tasks
syclik opened this issue Nov 19, 2013 · 4 comments
Closed
3 tasks

Refactor src/stan/gm/command.hpp: debugging is difficult as is. #405

syclik opened this issue Nov 19, 2013 · 4 comments

Comments

@syclik
Copy link
Member

syclik commented Nov 19, 2013

Issues like #379 are masked by the structure of src/stan/gm/command.hpp. Here are some things that should be done:

  • consistent use of return codes. Use the values in src/stan/gm/error_codes.hpp
  • remove switch in command()
    • use of sampler_select is opaque. Too hard to see which sampler is actually being called.
  • double check all exit codes
    • currently, there are no tests for how this exits

We should shift focus of this code and favor clarity and maintainability. This code should be Stan's interface to be utilized by CmdStan, RStan, and PyStan. (CmdStan and RStan currently does this. I'm not sure about PyStan.)

@syclik
Copy link
Member Author

syclik commented Nov 19, 2013

#392 is a similar issue and deals with the switch statement.

@betanalpha
Copy link
Contributor

@syclik syclik self-assigned this May 13, 2015
@syclik
Copy link
Member Author

syclik commented May 13, 2015

We'll fix this with #1361.

@syclik syclik modified the milestones: v2.8.0++, Future Oct 31, 2015
@syclik
Copy link
Member Author

syclik commented Oct 31, 2015

I'm closing this issue. It's being addressed in other issues and the file has moved to CmdStan.

@syclik syclik closed this as completed Oct 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants