You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Issues like #379 are masked by the structure of src/stan/gm/command.hpp. Here are some things that should be done:
consistent use of return codes. Use the values in src/stan/gm/error_codes.hpp
remove switch in command()
use of sampler_select is opaque. Too hard to see which sampler is actually being called.
double check all exit codes
currently, there are no tests for how this exits
We should shift focus of this code and favor clarity and maintainability. This code should be Stan's interface to be utilized by CmdStan, RStan, and PyStan. (CmdStan and RStan currently does this. I'm not sure about PyStan.)
The text was updated successfully, but these errors were encountered:
Issues like #379 are masked by the structure of src/stan/gm/command.hpp. Here are some things that should be done:
sampler_select
is opaque. Too hard to see which sampler is actually being called.We should shift focus of this code and favor clarity and maintainability. This code should be Stan's interface to be utilized by CmdStan, RStan, and PyStan. (CmdStan and RStan currently does this. I'm not sure about PyStan.)
The text was updated successfully, but these errors were encountered: