Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jacobian warning suggests using deprecated increment_log_prob() #2066

Closed
bgoodri opened this issue Sep 10, 2016 · 1 comment
Closed

Jacobian warning suggests using deprecated increment_log_prob() #2066

bgoodri opened this issue Sep 10, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@bgoodri
Copy link
Contributor

bgoodri commented Sep 10, 2016

Summary:

Jacobian warning suggests using deprecated increment_log_prob(). It should suggest target +=

Description:

Jacobian warning suggests using deprecated increment_log_prob(). It should suggest target +=

Reproducible Steps:

Parse

parameters {
  real<lower=0> y;
}
model {
  sqrt(y) ~ gamma(0.001, 0.001);
}

Current Output:

DIAGNOSTIC(S) FROM PARSER:
Warning (non-fatal):
Left-hand side of sampling statement (~) may contain a non-linear transform of a parameter or local variable.
If so, you need to call increment_log_prob() with the log absolute determinant of the Jacobian of the transform.
Left-hand-side of sampling statement:
    sqrt(y) ~ gamma(...)

Expected Output:

DIAGNOSTIC(S) FROM PARSER:
Warning (non-fatal):
Left-hand side of sampling statement (~) may contain a non-linear transform of a parameter or local variable.
If so, you need to call target += with the log absolute determinant of the Jacobian of the transform.
Left-hand-side of sampling statement:
    sqrt(y) ~ gamma(...)

Additional Information:

None

Current Version:

v2.12.0

@bgoodri bgoodri added the bug label Sep 10, 2016
@bgoodri bgoodri added this to the v2.12.0++ milestone Sep 10, 2016
@bob-carpenter
Copy link
Contributor

Thanks. I'll fix that and look for other occurrences of deprecated functions in warning messages.

@syclik syclik modified the milestones: v2.13.0, 2.13.0++ Oct 22, 2016
@syclik syclik closed this as completed in 2aa4e85 Oct 26, 2016
syclik added a commit that referenced this issue Oct 26, 2016
@syclik syclik modified the milestones: v2.13.0++, v2.13.0 Nov 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants