Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #419 +/- ##
==========================================
+ Coverage 98.62% 98.66% +0.04%
==========================================
Files 35 35
Lines 5798 5830 +32
==========================================
+ Hits 5718 5752 +34
+ Misses 80 78 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Fantastic, thank you! I will doubtlessly have a use case for this in the next two weeks, and I will report if there's any issues. |
|
@behramulukir, sorry for the basic question, but how do I get to the function? I don't see it when I install the latest development version of bayesplot. |
Collaborator
Author
|
Did you install the correct branch @mhollanders? As the changes are not merged to the master branch yet, you should install the branch I am working on. You can do it with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
ppc_rootogram_groupedfunction requested at #377. If you have any feedback, I am happy to hear @mhollanders.ppc_rootogram_groupedsimply creates multiple facets (plots) of the rootogram based on the grouping user passes to the function as an argument.Something to note here is that in
ppc_bars_grouped,force_axes_in_facetsfunction is used to make sure all facets have axes. This was resulting in errors when used withppc_rootogram_grouped(style="discrete")since-Infresults inNaNwhen used withscale_y_sqrt(). It was still used in other rootogram styles, but so far, I hadn't managed to get it working for discrete style. I'll mark this PR as ready once I find a solution to that.Tasks:
discretestyleExamples