remove y-axis line from mcmc_dots and mcmc_dots_by_chain

behramulukir · behramulukir · commit 9b2fa2638622 · 2026-01-13T14:46:16.000+02:00
diff --git a/R/mcmc-distributions.R b/R/mcmc-distributions.R
@@ -689,7 +689,7 @@ mcmc_dots_by_chain <- function(
     }
     graph <- graph +
       do.call("facet_grid", facet_args) +
-      force_axes_in_facets()
+      force_x_axis_in_facets()
   }
 
   if (n_param == 1) {
@@ -702,5 +702,6 @@ mcmc_dots_by_chain <- function(
     yaxis_text(FALSE) +
     yaxis_title(FALSE) +
     yaxis_ticks(FALSE) +
+    theme(axis.line.y = element_blank()) +
     xaxis_title(on = n_param == 1)
 }
diff --git a/tests/testthat/_snaps/mcmc-distributions/mcmc-dots-by-chain-default.svg b/tests/testthat/_snaps/mcmc-distributions/mcmc-dots-by-chain-default.svg
@@ -526,7 +526,6 @@
 <circle cx='292.02' cy='153.34' r='1.47' style='stroke-width: 1.06; stroke: #005B96; fill: #6497B1;' />
 <circle cx='324.42' cy='153.34' r='1.47' style='stroke-width: 1.06; stroke: #005B96; fill: #6497B1;' />
 <line x1='5.98' y1='155.88' x2='339.58' y2='155.88' style='stroke-width: 0.85; stroke-linecap: butt;' />
-<line x1='5.98' y1='155.88' x2='5.98' y2='44.09' style='stroke-width: 0.85; stroke-linecap: butt;' />
 </g>
 <g clip-path='url(#cpMC4wMHw3MjAuMDB8MC4wMHw1NzYuMDA=)'>
 </g>
@@ -1037,7 +1036,6 @@
 <circle cx='281.66' cy='282.22' r='1.65' style='stroke-width: 1.06; stroke: #005B96; fill: #6497B1;' />
 <circle cx='281.66' cy='277.89' r='1.65' style='stroke-width: 1.06; stroke: #005B96; fill: #6497B1;' />
 <line x1='5.98' y1='289.27' x2='339.58' y2='289.27' style='stroke-width: 0.85; stroke-linecap: butt;' />
-<line x1='5.98' y1='289.27' x2='5.98' y2='177.48' style='stroke-width: 0.85; stroke-linecap: butt;' />
 </g>
 <g clip-path='url(#cpMC4wMHw3MjAuMDB8MC4wMHw1NzYuMDA=)'>
 </g>
@@ -1548,7 +1546,6 @@
 <circle cx='305.38' cy='420.04' r='1.54' style='stroke-width: 1.06; stroke: #005B96; fill: #6497B1;' />
 <circle cx='316.47' cy='420.04' r='1.54' style='stroke-width: 1.06; stroke: #005B96; fill: #6497B1;' />
 <line x1='5.98' y1='422.66' x2='339.58' y2='422.66' style='stroke-width: 0.85; stroke-linecap: butt;' />
-<line x1='5.98' y1='422.66' x2='5.98' y2='310.87' style='stroke-width: 0.85; stroke-linecap: butt;' />
 </g>
 <g clip-path='url(#cpMC4wMHw3MjAuMDB8MC4wMHw1NzYuMDA=)'>
 </g>
@@ -2059,7 +2056,6 @@
 <circle cx='287.47' cy='553.53' r='1.44' style='stroke-width: 1.06; stroke: #005B96; fill: #6497B1;' />
 <circle cx='295.37' cy='553.53' r='1.44' style='stroke-width: 1.06; stroke: #005B96; fill: #6497B1;' />
 <line x1='5.98' y1='556.04' x2='339.58' y2='556.04' style='stroke-width: 0.85; stroke-linecap: butt;' />
-<line x1='5.98' y1='556.04' x2='5.98' y2='444.26' style='stroke-width: 0.85; stroke-linecap: butt;' />
 </g>
 <g clip-path='url(#cpMC4wMHw3MjAuMDB8MC4wMHw1NzYuMDA=)'>
 </g>
@@ -2570,7 +2566,6 @@
 <circle cx='643.72' cy='153.41' r='1.39' style='stroke-width: 1.06; stroke: #005B96; fill: #6497B1;' />
 <circle cx='651.27' cy='153.41' r='1.39' style='stroke-width: 1.06; stroke: #005B96; fill: #6497B1;' />
 <line x1='361.18' y1='155.88' x2='694.78' y2='155.88' style='stroke-width: 0.85; stroke-linecap: butt;' />
-<line x1='361.18' y1='155.88' x2='361.18' y2='44.09' style='stroke-width: 0.85; stroke-linecap: butt;' />
 </g>
 <g clip-path='url(#cpMC4wMHw3MjAuMDB8MC4wMHw1NzYuMDA=)'>
 </g>
@@ -3081,7 +3076,6 @@
 <circle cx='633.45' cy='286.82' r='1.37' style='stroke-width: 1.06; stroke: #005B96; fill: #6497B1;' />
 <circle cx='679.62' cy='286.82' r='1.37' style='stroke-width: 1.06; stroke: #005B96; fill: #6497B1;' />
 <line x1='361.18' y1='289.27' x2='694.78' y2='289.27' style='stroke-width: 0.85; stroke-linecap: butt;' />
-<line x1='361.18' y1='289.27' x2='361.18' y2='177.48' style='stroke-width: 0.85; stroke-linecap: butt;' />
 </g>
 <g clip-path='url(#cpMC4wMHw3MjAuMDB8MC4wMHw1NzYuMDA=)'>
 </g>
@@ -3592,7 +3586,6 @@
 <circle cx='630.75' cy='412.93' r='1.31' style='stroke-width: 1.06; stroke: #005B96; fill: #6497B1;' />
 <circle cx='645.14' cy='420.27' r='1.31' style='stroke-width: 1.06; stroke: #005B96; fill: #6497B1;' />
 <line x1='361.18' y1='422.66' x2='694.78' y2='422.66' style='stroke-width: 0.85; stroke-linecap: butt;' />
-<line x1='361.18' y1='422.66' x2='361.18' y2='310.87' style='stroke-width: 0.85; stroke-linecap: butt;' />
 </g>
 <g clip-path='url(#cpMC4wMHw3MjAuMDB8MC4wMHw1NzYuMDA=)'>
 </g>
@@ -4103,7 +4096,6 @@
 <circle cx='634.06' cy='549.70' r='1.41' style='stroke-width: 1.06; stroke: #005B96; fill: #6497B1;' />
 <circle cx='639.88' cy='553.56' r='1.41' style='stroke-width: 1.06; stroke: #005B96; fill: #6497B1;' />
 <line x1='361.18' y1='556.04' x2='694.78' y2='556.04' style='stroke-width: 0.85; stroke-linecap: butt;' />
-<line x1='361.18' y1='556.04' x2='361.18' y2='444.26' style='stroke-width: 0.85; stroke-linecap: butt;' />
 </g>
 <g clip-path='url(#cpMC4wMHw3MjAuMDB8MC4wMHw1NzYuMDA=)'>
 </g>
@@ -4184,10 +4176,6 @@
 <text x='523.70' y='568.03' text-anchor='middle' style='font-size: 9.60px; fill: #4D4D4D; font-family: sans;' textLength='5.34px' lengthAdjust='spacingAndGlyphs'>0</text>
 <text x='603.90' y='568.03' text-anchor='middle' style='font-size: 9.60px; fill: #4D4D4D; font-family: sans;' textLength='5.34px' lengthAdjust='spacingAndGlyphs'>2</text>
 <text x='684.10' y='568.03' text-anchor='middle' style='font-size: 9.60px; fill: #4D4D4D; font-family: sans;' textLength='5.34px' lengthAdjust='spacingAndGlyphs'>4</text>
-<polyline points='5.98,155.88 5.98,44.09 ' style='stroke-width: 0.85; stroke-linecap: butt;' />
-<polyline points='5.98,289.27 5.98,177.48 ' style='stroke-width: 0.85; stroke-linecap: butt;' />
-<polyline points='5.98,422.66 5.98,310.87 ' style='stroke-width: 0.85; stroke-linecap: butt;' />
-<polyline points='5.98,556.04 5.98,444.26 ' style='stroke-width: 0.85; stroke-linecap: butt;' />
 <text x='5.98' y='15.89' style='font-size: 14.40px; font-family: sans;' textLength='196.14px' lengthAdjust='spacingAndGlyphs'>mcmc_dots_by_chain (default)</text>
 </g>
 </svg>
diff --git a/tests/testthat/_snaps/mcmc-distributions/mcmc-dots-default.svg b/tests/testthat/_snaps/mcmc-distributions/mcmc-dots-default.svg
@@ -668,11 +668,6 @@
 <text x='619.96' y='284.65' text-anchor='middle' style='font-size: 9.60px; fill: #4D4D4D; font-family: sans;' textLength='5.34px' lengthAdjust='spacingAndGlyphs'>1</text>
 <text x='658.79' y='284.65' text-anchor='middle' style='font-size: 9.60px; fill: #4D4D4D; font-family: sans;' textLength='5.34px' lengthAdjust='spacingAndGlyphs'>2</text>
 <text x='697.62' y='284.65' text-anchor='middle' style='font-size: 9.60px; fill: #4D4D4D; font-family: sans;' textLength='5.34px' lengthAdjust='spacingAndGlyphs'>3</text>
-<polyline points='492.41,272.66 492.41,44.09 ' style='stroke-width: 0.85; stroke-linecap: butt;' />
-<polyline points='249.19,272.66 249.19,44.09 ' style='stroke-width: 0.85; stroke-linecap: butt;' />
-<polyline points='249.19,556.04 249.19,327.48 ' style='stroke-width: 0.85; stroke-linecap: butt;' />
-<polyline points='5.98,272.66 5.98,44.09 ' style='stroke-width: 0.85; stroke-linecap: butt;' />
-<polyline points='5.98,556.04 5.98,327.48 ' style='stroke-width: 0.85; stroke-linecap: butt;' />
 <text x='5.98' y='15.89' style='font-size: 14.40px; font-family: sans;' textLength='130.47px' lengthAdjust='spacingAndGlyphs'>mcmc_dots (default)</text>
 </g>
 </svg>

Original file line number	Diff line number	Diff line change
`@@ -689,7 +689,7 @@ mcmc_dots_by_chain <- function(`
`689`	`689`	`}`
`690`	`690`	`graph <- graph +`
`691`	`691`	`do.call("facet_grid", facet_args) +`
`692`		`- force_axes_in_facets()`
	`692`	`+ force_x_axis_in_facets()`
`693`	`693`	`}`
`694`	`694`
`695`	`695`	`if (n_param == 1) {`
`@@ -702,5 +702,6 @@ mcmc_dots_by_chain <- function(`
`702`	`702`	`yaxis_text(FALSE) +`
`703`	`703`	`yaxis_title(FALSE) +`
`704`	`704`	`yaxis_ticks(FALSE) +`
	`705`	`+ theme(axis.line.y = element_blank()) +`
`705`	`706`	`xaxis_title(on = n_param == 1)`
`706`	`707`	`}`