-
-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra operators to Stream #215
Comments
@staltz what do you think about it? |
I think this duplicates #128 a little bit, but in general this sounds like it would be helpful. There were some open questions about TypeScript help when patching, but |
I was to comment exactly that: https://github.com/ReactiveX/rxjs/blob/master/src/add/operator/buffer.ts
|
I know about #128, but the problem with So I propose to create a separate class that extends common xstream with all the extra methods seem to me as the only normal solution. ES6 tree shaking is here to solve this so "important" front-end bundle size question, for those who really care (I don't care much). |
I think it would be useful to have version of
xs
ofExtraStream
type that would have methods likeflattenConcurrently
,sampleCombine
on it defined so they can be used withoutcompose
semantics.It could be imported from
import xs, {Stream} from 'xstream/extra'
Or maybe just add those methods on common
Stream
type, and add them dynamically on Stream prototype when importingxstream/extra/...
The text was updated successfully, but these errors were encountered: