Fix notification sound not playing (sindresorhus#274)

notlmn · web-flow · commit 7a01849be9ce · 2023-02-06T20:45:39.000+05:30
diff --git a/source/lib/notifications-service.js b/source/lib/notifications-service.js
@@ -118,9 +118,9 @@ export async function showNotifications(notifications) {
 	}
 }
 
-export async function playNotificationSound() {
+export function playNotificationSound() {
 	const audio = new Audio();
-	audio.src = await browser.extension.getURL('/sounds/bell.ogg');
+	audio.src = browser.runtime.getURL('sounds/bell.ogg');
 	audio.play();
 }
 
@@ -138,8 +138,8 @@ export async function checkNotifications(lastModified) {
 		/* eslint-enable camelcase */
 	}
 
-	if (playNotifSound && notifications.length > 1) {
-		await playNotificationSound();
+	if (playNotifSound && notifications.length > 0) {
+		playNotificationSound();
 	}
 
 	if (showDesktopNotif) {

Original file line number	Diff line number	Diff line change
`@@ -118,9 +118,9 @@ export async function showNotifications(notifications) {`
`118`	`118`	`}`
`119`	`119`	`}`
`120`	`120`
`121`		`-export async function playNotificationSound() {`
	`121`	`+export function playNotificationSound() {`
`122`	`122`	`const audio = new Audio();`
`123`		`- audio.src = await browser.extension.getURL('/sounds/bell.ogg');`
	`123`	`+ audio.src = browser.runtime.getURL('sounds/bell.ogg');`
`124`	`124`	`audio.play();`
`125`	`125`	`}`
`126`	`126`
`@@ -138,8 +138,8 @@ export async function checkNotifications(lastModified) {`
`138`	`138`	`/* eslint-enable camelcase */`
`139`	`139`	`}`
`140`	`140`
`141`		`- if (playNotifSound && notifications.length > 1) {`
`142`		`- await playNotificationSound();`
	`141`	`+ if (playNotifSound && notifications.length > 0) {`
	`142`	`+ playNotificationSound();`
`143`	`143`	`}`
`144`	`144`
`145`	`145`	`if (showDesktopNotif) {`