Removing microblock test tests::epoch_25::microblocks_disabled

[wileyj]

This removes the consistently failing test in the CI workflow epoch-tests.yml

Since microblocks are disabled, we do also have these test that remain and can likely be removed from bitcoin-tests.yml as well:

https://github.com/stacks-network/stacks-core/blob/develop/.github/workflows/bitcoin-tests.yml#L79-L93

Incidentally, from above file - it seems like we can likely remove the older epoch tests as well.

bitcoin-tests.yml:

• tests::neon_integrations::test_competing_miners_build_anchor_blocks_and_microblocks_on_same_chain
• tests::neon_integrations::bad_microblock_pubkey
• tests::neon_integrations::microblock_fork_poison_integration_test
• tests::neon_integrations::microblock_integration_test
• tests::neon_integrations::microblock_large_tx_integration_test_FLAKY
• tests::neon_integrations::microblock_limit_hit_integration_test
• tests::neon_integrations::microblock_miner_multiple_attempts
• tests::neon_integrations::test_problematic_microblocks_are_not_mined
• tests::neon_integrations::test_problematic_microblocks_are_not_relayed_or_stored
• tests::neon_integrations::runtime_overflow_unconfirmed_microblocks_integration_test
• tests::neon_integrations::size_overflow_unconfirmed_invalid_stream_microblocks_integration_test
• tests::neon_integrations::size_overflow_unconfirmed_microblocks_integration_test
• tests::neon_integrations::size_overflow_unconfirmed_stream_microblocks_integration_test
• tests::epoch_25::microblocks_disabled

related: #5892
#5894

[wileyj]

I can remove the other tests as well based on review, for now i've kept this simple to target only the specified test that is failing.

[jcnelson]

Can you also remove the test itself? We can always restore it later from git history.

[wileyj]

Can you also remove the test itself? We can always restore it later from git history.

I can - any preference on the other tests I've listed? quite happy to remove them as well (or a subset of them)

[wileyj]

Removed all listed microblock tests, with the addition of tests::epoch_205::bigger_microblock_streams_in_2_05

[obycode]

LGTM!

[obycode]

Can you also remove make_signed_microblock and clean up some unused imports?

[obycode]

and make_mblock_tx_chain

[obycode]

👍

[wileyj]

latest commits ended up removing these tests:

chainstate::stacks::db::transactions::test::process_poison_microblock_same_block
chainstate::stacks::db::transactions::test::process_poison_microblock_multiple_same_block
chainstate::stacks::db::transactions::test::process_poison_microblock_invalid_transaction
tests::neon_integrations::microblock_fork_poison_integration_test

edit: reverted in f4f234b and 500c434

[jcnelson]

We should keep the unit tests because we need to retain the ability to process poison microblock transactions (there are many in the chain history). But it's fine to drop the integration tests.

[obycode]

LGTM

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.82%. Comparing base (376ed5a) to head (6b9771d).
Report is 3736 commits behind head on develop.

❌ Your project status has failed because the head coverage (78.82%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5895      +/-   ##
===========================================
- Coverage    81.19%   78.82%   -2.38%     
===========================================
  Files          490      520      +30     
  Lines       351570   379606   +28036     
  Branches       323      323              
===========================================
+ Hits        285460   299219   +13759     
- Misses       66102    80379   +14277     
  Partials         8        8              

Files with missing lines	Coverage Δ
testnet/stacks-node/src/tests/epoch_205.rs	0.00% <ø> (ø)
testnet/stacks-node/src/tests/mod.rs	89.09% <ø> (-0.89%)	⬇️
testnet/stacks-node/src/tests/neon_integrations.rs	59.78% <ø> (-11.88%)	⬇️

... and 412 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5f0ed8...6b9771d. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.