-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make chain_id
configurable
#5300
Conversation
Error if an unknown field is found in a node's config file. This is helpful to catch errors in the config file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but please test this (or add tests) before merging to confirm that once the PeerDB
is connected, the LocalPeer
you load out of it has a network_id
equal to chain_id
.
Are there any existing tests that might be a good setup for this that you could point me to? |
You could add an assertion to any of the neon or nakamoto integration tests by querying /v2/info |
Cool, I was thinking about adding an integration test with this any way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved pending CI
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml