Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: /v3/sortitions calculation and tenure extend behavior #5254

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

kantai
Copy link
Member

@kantai kantai commented Sep 27, 2024

This fixes two issues that came up in nakamoto testnet (probably only #5252 came up so far -- still investigating the details of #5248)

@kantai kantai requested a review from a team as a code owner September 27, 2024 19:23
@wileyj
Copy link
Contributor

wileyj commented Sep 28, 2024

maybe the target branch here should be the rc branch? then we would PR the rc branch back to develop.
I do have some unmerged docs around this in a different PR. i'll see if i can push that forward.

jcnelson
jcnelson previously approved these changes Sep 30, 2024
jferrant
jferrant previously approved these changes Sep 30, 2024
@kantai kantai dismissed stale reviews from jferrant and jcnelson via a50b4a9 September 30, 2024 15:27
@kantai
Copy link
Member Author

kantai commented Sep 30, 2024

The four failing tests in CI:

tests::signer::v0::min_gap_between_blocks — passes locally
tests::signer::v0::partial_tenure_fork — passes locally
tests::signer::v0::bitcoind_forking_test — passes locally
tests::signer::v0::multiple_miners_with_nakamoto_blocks — fails in develop

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kantai kantai added this pull request to the merge queue Oct 1, 2024
Merged via the queue into develop with commit c39ba88 Oct 1, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants