Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Mutants: Action Membership Run #5083

Merged
merged 14 commits into from
Aug 22, 2024
Merged

CI Mutants: Action Membership Run #5083

merged 14 commits into from
Aug 22, 2024

Conversation

ASuciuX
Copy link
Contributor

@ASuciuX ASuciuX commented Aug 16, 2024

This is the PR enabling the full manual dispatch of the mutants CI so that they could run for more than 6 hours. It has a custom action limiting the access to trigger that only to the wanted team.

This should be merged only after:

  1. the Master PR is merged which enables a GUI button to trigger this and make it testable CI Mutants: add workfow dispatch for GUI #5082
  2. the composite action is merged and fully functional Add custom CI to run mutation testing completely manually by users from a given team actions#50

@ASuciuX ASuciuX force-pushed the ci/custom-action-membership branch 2 times, most recently from 2b36a5d to 8107bf9 Compare August 16, 2024 17:03
@wileyj
Copy link
Contributor

wileyj commented Aug 16, 2024

waiting on successful run from changes in #5082 before merging this. changes appear fine

@ASuciuX ASuciuX changed the title CI Mutants: Action Membership Tun CI Mutants: Action Membership Run Aug 16, 2024
@ASuciuX
Copy link
Contributor Author

ASuciuX commented Aug 18, 2024

wileyj
wileyj previously approved these changes Aug 19, 2024
Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@wileyj wileyj enabled auto-merge August 19, 2024 15:53
@smcclellan smcclellan requested a review from obycode August 19, 2024 17:28
@wileyj wileyj self-requested a review August 19, 2024 20:24
automatically proceed from the action's context
@ASuciuX ASuciuX requested a review from obycode August 21, 2024 14:53
@wileyj
Copy link
Contributor

wileyj commented Aug 21, 2024

changes after addressing comments from @obycode and the conditionals i recommended look good.
However, i think these changes should also be merged into master else they won't take effect until the next time a release branch is merged there (it may be a few weeks at the earliest).

could you cherry-pick these commits in a new PR based off of master to override #5082 ?

otherwise, these changes look good to me

@ASuciuX
Copy link
Contributor Author

ASuciuX commented Aug 21, 2024

could you cherry-pick these commits in a new PR based off of master to override #5082 ?

sure, #5100

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@wileyj wileyj added this pull request to the merge queue Aug 22, 2024
Merged via the queue into develop with commit f16beb3 Aug 22, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Mutation Testing - ci workflow add threshold nr of mutants to not run on CI
4 participants