Disable Microblocks in Epoch 2.5

[kantai]

Description

This PR disables microblock production and confirmation in Epoch 2.5 and will reject any blocks that attempt to confirm microblocks in Epoch 2.5 and beyond.

This is tested with a new integration test that first mines some blocks in Epoch 2.5 with a microblock only tx in the mempool, asserting that the transaction does not get confirmed and no new microblocks are produced. It then sets a test only flag which tells the miner to mine microblocks in 2.5 anyways, and asserts that the microblocks are produced but never confirmed. Finally, it sets another flag which tells the miner to confirm microblocks in 2.5 anyways, and asserts that the miner's blocks are no longer accepted.

Applicable issues

#4479

[codecov]

Codecov Report

Attention: Patch coverage is 98.28571% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 83.35%. Comparing base (80adc27) to head (c9a97cb).
Report is 11 commits behind head on next.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #4561      +/-   ##
==========================================
- Coverage   83.35%   83.35%   -0.01%     
==========================================
  Files         453      454       +1     
  Lines      328491   328792     +301     
  Branches      323      323              
==========================================
+ Hits       273822   274072     +250     
- Misses      54661    54712      +51     
  Partials        8        8              

Files	Coverage Δ
stackslib/src/chainstate/burn/db/sortdb.rs	91.97% <100.00%> (-0.05%)	⬇️
stackslib/src/chainstate/coordinator/tests.rs	90.78% <100.00%> (ø)
stackslib/src/chainstate/stacks/db/blocks.rs	90.05% <100.00%> (+0.02%)	⬆️
stackslib/src/chainstate/stacks/miner.rs	81.04% <100.00%> (-0.01%)	⬇️
...lib/src/chainstate/stacks/tests/chain_histories.rs	95.71% <100.00%> (ø)
stackslib/src/net/mod.rs	72.92% <100.00%> (ø)
testnet/stacks-node/src/config.rs	63.91% <100.00%> (+0.02%)	⬆️
testnet/stacks-node/src/neon_node.rs	83.00% <100.00%> (+0.13%)	⬆️
testnet/stacks-node/src/tests/mod.rs	89.76% <ø> (ø)
testnet/stacks-node/src/tests/epoch_25.rs	97.39% <97.39%> (ø)

... and 19 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80adc27...c9a97cb. Read the comment docs.

[jcnelson]

The code overall LGTM, so I'll approve for now. However, I think we'll also want to update the mempool admission logic to reject microblock-only transactions at epoch 2.5. That can be a separate PR if you want

[kantai]

The code overall LGTM, so I'll approve for now. However, I think we'll also want to update the mempool admission logic to reject microblock-only transactions at epoch 2.5. That can be a separate PR if you want

Yep -- we would probably also want to update the microblock downloading logic to reject microblocks after Epoch 2.5, but like the mempool changes, since those are not consensus critical, I'd prefer to handle them in a follow on PR.

[obycode]

LGTM. My only thought was about the mempool rejection for transactions after 2.5 with the wrong anchor mode, but I see that was already discussed.

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.