Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add config parameters for burn block start #4556

Merged
merged 9 commits into from
Mar 22, 2024
Merged

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Mar 18, 2024

Description

Added configuration parameters to customize the burn block at which to start processing Stacks blocks, when running on testnet or regtest.

[burnchain]
first_burn_block_height = 2582526
first_burn_block_timestamp = 1710780828
first_burn_block_hash = "000000000000001a17c68d43cb577d62074b63a09805e4a07e829ee717507f66"

Applicable issues

  • N/A

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@obycode obycode force-pushed the feat/config-start-block branch from dc2c59e to d8bf9e7 Compare March 18, 2024 17:34
@obycode obycode force-pushed the feat/config-start-block branch from d8bf9e7 to 420f132 Compare March 18, 2024 17:51
@obycode obycode requested review from kantai and hstove March 18, 2024 17:56
kantai
kantai previously approved these changes Mar 18, 2024
Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kantai
kantai previously approved these changes Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 61.68224% with 82 lines in your changes are missing coverage. Please review.

Project coverage is 66.75%. Comparing base (25311e4) to head (117d8be).
Report is 4 commits behind head on next.

Additional details and impacted files
@@             Coverage Diff             @@
##             next    #4556       +/-   ##
===========================================
- Coverage   84.37%   66.75%   -17.62%     
===========================================
  Files         471      471               
  Lines      337762   337942      +180     
  Branches      317      317               
===========================================
- Hits       284973   225609    -59364     
- Misses      52781   112325    +59544     
  Partials        8        8               
Files Coverage Δ
stackslib/src/net/api/tests/mod.rs 97.52% <100.00%> (+0.01%) ⬆️
stackslib/src/net/mod.rs 73.24% <100.00%> (-1.37%) ⬇️
testnet/stacks-node/src/tenure.rs 100.00% <100.00%> (ø)
stackslib/src/chainstate/stacks/miner.rs 78.56% <91.66%> (-2.12%) ⬇️
...-node/src/burnchains/bitcoin_regtest_controller.rs 77.70% <92.30%> (-10.71%) ⬇️
testnet/stacks-node/src/nakamoto_node/miner.rs 83.46% <0.00%> (+0.33%) ⬆️
testnet/stacks-node/src/neon_node.rs 82.15% <66.66%> (-0.82%) ⬇️
...tackslib/src/chainstate/stacks/boot/pox_2_tests.rs 59.21% <0.00%> (-37.23%) ⬇️
stackslib/src/chainstate/stacks/db/blocks.rs 74.15% <71.42%> (-15.87%) ⬇️
stackslib/src/chainstate/stacks/db/unconfirmed.rs 51.50% <33.33%> (-42.64%) ⬇️
... and 8 more

... and 272 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25311e4...117d8be. Read the comment docs.

hstove
hstove previously approved these changes Mar 18, 2024
Epoch 1.0 must be before the start block and epoch 2.0 must be equal to
the start block.
@obycode obycode requested review from hstove and kantai March 21, 2024 18:38
kantai
kantai previously approved these changes Mar 21, 2024
@obycode obycode enabled auto-merge March 21, 2024 19:06
wileyj
wileyj previously approved these changes Mar 21, 2024
hstove
hstove previously approved these changes Mar 21, 2024
@obycode obycode dismissed stale reviews from hstove, wileyj, and kantai via 6319d3b March 22, 2024 14:05
kantai
kantai previously approved these changes Mar 22, 2024
wileyj
wileyj previously approved these changes Mar 22, 2024
@obycode obycode dismissed stale reviews from wileyj and kantai via 3bbcd92 March 22, 2024 16:33
@obycode obycode requested review from kantai and wileyj March 22, 2024 16:33
hstove
hstove previously approved these changes Mar 22, 2024
kantai
kantai previously approved these changes Mar 22, 2024
wileyj
wileyj previously approved these changes Mar 22, 2024
@obycode obycode dismissed stale reviews from wileyj, kantai, and hstove via 117d8be March 22, 2024 17:23
@obycode obycode requested review from kantai and hstove March 22, 2024 17:23
@obycode
Copy link
Contributor Author

obycode commented Mar 22, 2024

These failing tests were fixed in #4578.

@obycode obycode requested a review from wileyj March 22, 2024 18:52
@obycode obycode added this pull request to the merge queue Mar 22, 2024
Merged via the queue into next with commit 441b7ed Mar 22, 2024
1 of 2 checks passed
ASuciuX added a commit to ASuciuX/archived-stacks-core that referenced this pull request Mar 28, 2024
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants