Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes discovered while bringing up the pre-launch testnet #4527

Merged
merged 37 commits into from
Mar 15, 2024
Merged

Fixes discovered while bringing up the pre-launch testnet #4527

merged 37 commits into from
Mar 15, 2024

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Mar 12, 2024

Description

This includes fixes to all of the issues discovered during the process of bringing up and stabilizing the pre-launch testnet, as well as various improvements to logging that we found to be helpful in finding and understanding problems.

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

jferrant and others added 30 commits March 8, 2024 16:44
@jferrant @obycode
Have miners abort signing a block if the burn tip changes
e577139 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@obycode
chore: log coordinator state
db8f0cc
@kantai
feat: use block proposal struct for miner -> signers comms. check cla…
d56895a 
…imed reward-cycle
@kantai
Merge pull request #4511 from stacks-network/feat/proposal-reward-set…
c6d1bc1 
…-matching

Feat: use block proposal struct for miner -> signers communication
@kantai
feat: add a parity check and filter events sent to the signer instances
b9c9ece
@kantai
Merge pull request #4512 from stacks-network/feat/parity-check-signer…
18ad724 
…-events

feat: add a parity check and filter events sent to the signer instances
@kantai
logs: signer block responses to info. display formatting for block re…
b61b2be 
…sponse
@kantai
logs: better miner assembly and broadcasting logging
9232550
@kantai
logs: add coordinator id to signer binary logging
8cdbf08
@kantai
logs: improved rejection logging, debug logs in the db
a736360
@obycode
chore: cleanup excessive logging
31d5227
@obycode
chore: remove unused variable
dd95ad0
@jferrant @obycode
Cleanup outdated signers
9997c1b 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@jferrant @obycode
Cleanup outdated signer within refresh signer
59f2377 
Signed-off-by: Jacinta Ferrant <jacinta@trustmachines.co>
@hstove
fix: try not deleting accepted blocks from signerDB
d1d1365
@obycode
Merge pull request #4514 from stacks-network/fix/dont-remove-blocks
d79d26b 
fix: try not deleting accepted blocks from signerDB
@kantai
feat: signer does not treat repeated proposals as new
1d09299
@kantai
Merge pull request #4515 from stacks-network/feat/signer-ignore-repeats
fa691c2 
feat: signer does not treat repeated proposals as new
@obycode
chore: use index to make the code more readable
d24e1a0
@obycode
Merge pull request #4513 from stacks-network/bugfix/cleanup-outdated-…
249ee53 
…signers

Bugfix/cleanup outdated signers
@obycode
fix: use http/1.1, not http/1.0
f077e08
@hstove
feat: select coordinator just from pubkey alone
a1c226c
@obycode
chore: cleanup unused field
830b10d
@obycode
feat: skip rest of loop when signer's tenure has completed
fd17501
@obycode
logs: quiet warning when signer is not registered for future cycle
6daf973
@obycode
Merge pull request #4516 from stacks-network/brice/minor-changes
52f2c99 
Minor changes / clean up
@obycode
chore: ensure all http/1.1 requests are properly structured
17656a3
@hstove
feat: add const to determine whether to rotate coordinator
7891f7e
@obycode
fix: use two different blocks for signing test
3202e27
@hstove
Merge pull request #4517 from stacks-network/fix/dont-rotate-coordina…
24a177d 
…tors

feat: add const to determine whether to rotate coordinator
@obycode
chore: delete commented code
49eb61a 
We decided that since the signerdb is in the filesystem, we do not need
to garbage collect it.
netrome
netrome reviewed Mar 13, 2024
View reviewed changes
Copy link
Contributor

@netrome netrome left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor nits from my side but nothing major. I'll approve once Jude's comments are addressed.

stacks-signer/src/signerdb.rs Show resolved Hide resolved
stacks-signer/src/signer.rs Show resolved Hide resolved
jferrant
jferrant previously approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@jferrant jferrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice to see all these changes!

zone117x
zone117x previously approved these changes Mar 14, 2024
View reviewed changes
@jcnelson jcnelson self-requested a review March 15, 2024 14:20
jcnelson
jcnelson previously approved these changes Mar 15, 2024
View reviewed changes
netrome
netrome previously approved these changes Mar 15, 2024
View reviewed changes
@kantai kantai dismissed stale reviews from netrome, jcnelson, zone117x, and jferrant via 6e4d9cc March 15, 2024 16:43
@kantai kantai enabled auto-merge March 15, 2024 16:43
@kantai kantai disabled auto-merge March 15, 2024 16:43
@zone117x zone117x enabled auto-merge March 15, 2024 17:16
@zone117x zone117x added this pull request to the merge queue Mar 15, 2024
Merged via the queue into next with commit 6278946 Mar 15, 2024
1 of 2 checks passed
@obycode obycode deleted the dream-team-fixes branch March 18, 2024 20:53
ASuciuX added a commit to ASuciuX/archived-stacks-core that referenced this pull request Apr 2, 2024
@ASuciuX
added the mutants from PR stacks-network#4527
62a7e6e
This was referenced Apr 2, 2024
Closed
Closed
@ASuciuX ASuciuX mentioned this pull request May 14, 2024
Merged
10 tasks
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kantai kantai kantai left review comments

@jferrant jferrant jferrant approved these changes

@zone117x zone117x zone117x approved these changes

@netrome netrome netrome left review comments

@jcnelson jcnelson jcnelson left review comments

@setzeus setzeus Awaiting requested review from setzeus

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@obycode @blockstack-devops @jcnelson @kantai @zone117x @jferrant @netrome @hstove