-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add pox_stx_threshold
amount to /new_block
event data
#4524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4524 +/- ##
==========================================
- Coverage 83.29% 82.41% -0.88%
==========================================
Files 452 452
Lines 326071 326098 +27
Branches 323 323
==========================================
- Hits 271594 268756 -2838
- Misses 54469 57334 +2865
Partials 8 8
... and 53 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Event indexers (e.g. the Stacks API) analyze historical pox-4 events to generate rich signer data. One of the challenges is determining which past stacking transactions should be considered for a given pox cycle. In this case, we want the ability to know if a historical pox-4 stacking event was discarded because of not meeting the minimum stx threshold (i.e. not given any slots/weight).
This PR adds the
(stx) threshold
value used for a given cycle's reward calculations to the/new_block
event payload.