Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: use block proposal struct for miner -> signers communication #4511

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

kantai
Copy link
Contributor

@kantai kantai commented Mar 9, 2024

This uses a struct for communicating a block proposal from the miner to signers.

The signer also checks the claimed reward cycle of the block before attempting to validate the proposal.

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 12 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (dream-team-fixes@db8f0cc). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             dream-team-fixes    #4511   +/-   ##
===================================================
  Coverage                    ?   70.47%           
===================================================
  Files                       ?      452           
  Lines                       ?   326113           
  Branches                    ?      323           
===================================================
  Hits                        ?   229824           
  Misses                      ?    96281           
  Partials                    ?        8           
Files Coverage Δ
stackslib/src/chainstate/nakamoto/miner.rs 76.09% <100.00%> (ø)
libsigner/src/events.rs 79.42% <94.73%> (ø)
testnet/stacks-node/src/nakamoto_node/miner.rs 79.27% <81.48%> (ø)
stacks-signer/src/signer.rs 70.52% <62.50%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db8f0cc...d56895a. Read the comment docs.

@kantai kantai merged commit c6d1bc1 into dream-team-fixes Mar 9, 2024
1 of 2 checks passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 4, 2024
@kantai kantai deleted the feat/proposal-reward-set-matching branch March 10, 2025 16:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants