-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update StackStxOp to include signer key #4412
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4412 +/- ##
==========================================
+ Coverage 83.33% 83.39% +0.06%
==========================================
Files 453 453
Lines 328494 329585 +1091
Branches 323 323
==========================================
+ Hits 273744 274853 +1109
+ Misses 54742 54724 -18
Partials 8 8
... and 22 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! I think this is pretty close. You should mainly add an integration test (like in nakamoto_integrations
)
08b6dd8
to
525ba04
Compare
Ah, I just realized that #4461 will require an update to this burn op (two new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great, I just have some comments around backwards compatibility with the existing burn op structure. Nice work!
testnet/stacks-node/src/burnchains/bitcoin_regtest_controller.rs
Outdated
Show resolved
Hide resolved
…nd pass to Clarity call in PoX-4
cd6a10a
to
3d2043e
Compare
…n only for backward compatibility
…nd pass to Clarity call in PoX-4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- just one comment trying to spread the good news about the PoxVersions enum.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Following the signer-key authorization in #4377, this PR updates stack-stx burn op (StackStxOp) to include signer-key.
Applicable issues