Nakamoto: remove stacker signature fields from tenure change payload #4260
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4260 +/- ##
==========================================
- Coverage 83.34% 83.11% -0.23%
==========================================
Files 432 432
Lines 306587 306549 -38
==========================================
- Hits 255521 254795 -726
- Misses 51066 51754 +688 ☔ View full report in Codecov by Sentry. |
| /// The Stacker signature | ||
| pub signature: ThresholdSignature, | ||
| /// A bitmap of which Stackers signed | ||
| pub signers: Vec<u8>, |
There was a problem hiding this comment.
Do we want this bitmap for blocks?
There was a problem hiding this comment.
Yes, but we can add that back in via a separate PR.
There was a problem hiding this comment.
Yep, I'm working on that in a separate PR.
|
Why is codecov misbehaving? |
I think it's just that codecov returns a report before all of the tests have run (it returns after the first test runs), but in order to get enough coverage, all the tests have to run, so while tests are still running, it seems like codecov is failing. Once everything has run (as it has now), codecov should pass (as it is now). |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Related to closing #3932 -- TenureChange payloads don't need stacker signatures, because stackers have to sign the block header, which incorporates the TenureChange payload in its tx hash.
The signer binary doesn't need to do anything special to validate these payloads: they have to sign off on blocks anyways, and the content of tenure change transactions is validated by the stacks-node's block proposal validation endpoint already.
Conveniently, this also doesn't place much of a burden on the stacks-node miner either: the nakamoto-neon miner was already constructing tenure change transactions in self-signing-mode , so this PR just makes it construct those transactions all the time.
Closes #4258