-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build metadata. don't trigger from pushed tags anymore #2276
Conversation
This works for me |
@kantai Did you see this part?
I'm wondering if the version and package name cannot be overridden by ENV vars because it's defined in the Cargo.toml. |
@CharlieC3 that's because code relies on The |
@diwakergupta The env vars are getting set before the build occurs. I also tried setting the env vars during runtime in the docker container just to test, but it doesn't seem to have any affect (as expected from the reasons you mentioned). |
} | ||
|
||
} else { | ||
return option_env!("GIT_COMMIT").map(String::from); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if there's a better way to convert a Option<&'static str>
to Option<String>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a perfect approach.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Updates the package name and version displayed in the
/v2/info
endpoint.server_version
at/v2/info
andstacks-node version
command should now read something similar to:"stacks-node v24.3.2.0-xenon (build-metadata:0087561+, release build, linux [x86_64])"
clarity-js-sdk
PR upon eachstacks-blockchain
release, a new tag that gets created by the standard release workflow will create a loop, causing the release workflow to run again and attempt re-releasing the version.Closes #2275
Closes https://github.com/blockstackpbc/devops/issues/554
Type of Change
Does this introduce a breaking change?
No
Are documentation updates required?
No
Testing information
docker run -p 20443:20443 --rm blockstack/stacks-blockchain:build-metadata-stretch
localhost:20443/v2/info
in a browser once to initial boot finishes.Checklist
npm run test
passes