chore: aac fix ParseError::CircularReference indeterminism, #6627

Author: federico-stacks

clarity/src/vm/ast/definition_sorter/mod.rs

@@ -90,7 +90,7 @@ impl DefinitionSorter {
         let sorted_indexes = walker.get_sorted_dependencies(&self.graph);
 
         if let Some(deps) = walker.get_cycling_dependencies(&self.graph, &sorted_indexes) {
-            let functions_names = deps
+            let mut function_names = deps
                 .into_iter()
                 .filter_map(|i| {
                     let exp = &contract_ast.pre_expressions[i];
@@ -99,7 +99,10 @@ impl DefinitionSorter {
                 .map(|i| i.0.to_string())
                 .collect::<Vec<_>>();
 
-            let error = ParseError::new(ParseErrors::CircularReference(functions_names));
+            // Sorting function names to make the error contents deterministic
+            function_names.sort();
+
+            let error = ParseError::new(ParseErrors::CircularReference(function_names));
             return Err(error);
         }
 

stackslib/src/chainstate/tests/parse_tests.rs

@@ -17,9 +17,9 @@
 use clarity::vm::ast::parser::v2::MAX_CONTRACT_NAME_LEN;
 use clarity::vm::ast::stack_depth_checker::AST_CALL_STACK_DEPTH_BUFFER;
 use clarity::vm::MAX_CALL_STACK_DEPTH;
-
 #[allow(unused_imports)] // Just used for documentation purpose
 use clarity::vm::{ast::errors::ParseErrors, representations::ContractName};
+
 use crate::chainstate::tests::consensus::contract_deploy_consensus_test;
 
 /// ParserError: [`ParseErrors::ExpressionStackDepthTooDeep`]