Skip to content

Commit e64e9c2

Browse files
committed
Unify Scanner and Collector determine-image-tag tasks
and add notes to later unify with the StackRox one. Scanner can be unified with Collector thanks to stackrox/scanner#1742 It could be that the ultimate unification will come in https://issues.redhat.com/browse/ROX-26026 but I created a new task anyway.
1 parent ca2c5e7 commit e64e9c2

3 files changed

+3
-54
lines changed

tasks/determine-image-tag-scanner-task.yaml

Lines changed: 0 additions & 53 deletions
This file was deleted.

tasks/determine-image-tag-stackrox-task.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ kind: Task
33
metadata:
44
name: determine-image-tag-stackrox
55
spec:
6+
# TODO(ROX-27384): this is a special task for the StackRox repo, unify with Scanner and Collector ones.
67
description: Determines the tag for the output image using the StackRox convention from 'make tag' output.
78
params:
89
- name: TAG_SUFFIX

tasks/determine-image-tag-collector-task.yaml renamed to tasks/determine-image-tag-task.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
apiVersion: tekton.dev/v1
22
kind: Task
33
metadata:
4-
name: determine-image-tag-collector
4+
name: determine-image-tag
55
spec:
6+
# TODO(ROX-27384): this is a task for Scanner and Collector repos, unify with the StackRox one.
67
description: Determines the tag for the output image using the StackRox convention from 'make tag' output.
78
params:
89
- name: TAG_SUFFIX

0 commit comments

Comments
 (0)