Add the managed registry type #176
Merged
+394
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements support for managed registries as per design doc Option 3
(explicit managed section).
Managed registries:
- Are directly managed via API (no external data source)
- Do not have sync loops (no automatic synchronization)
- Do not require syncPolicy or filter configuration
- Get initialized with "Complete" status instead of "Failed"
- Support the `managed: {}` configuration block
Implementation:
- Add SourceTypeManaged constant
- Add ManagedConfig type (empty struct, placeholder for future options)
- Update RegistryConfig to include Managed field
- Update validation to accept managed as fourth source type
- Update GetType() to return SourceTypeManaged when applicable
- Coordinator skips starting sync loops for managed registries
- Coordinator initializes managed registries with appropriate status
This aligns with the multi-registry architecture design document
and enables API-driven registry management for future extensions.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
This commit adds extensive test coverage for the managed registry type: Config validation tests (internal/config/config_test.go): - Valid managed registry without syncPolicy - Valid managed registry with ignored syncPolicy - Valid managed registry with ignored filter - Error cases for specifying managed with other source types - Mixed configurations with both managed and synced registries - Updated GetType() test to include managed type - Updated error messages to include "managed" in source type lists Coordinator tests (internal/sync/coordinator/coordinator_test.go): - Status initialization for managed registries (Complete vs Failed) - Mixed configurations with both managed and synced registries - Verification that managed registries get proper status messages All tests pass and verify that managed registries: - Don't require syncPolicy or filter fields - Initialize with SyncPhaseComplete status - Display appropriate message: "Managed registry (data managed via API)" - Can coexist with file/git/api synced registries 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #176 +/- ##
==========================================
+ Coverage 67.59% 68.05% +0.46%
==========================================
Files 54 54
Lines 3240 3262 +22
==========================================
+ Hits 2190 2220 +30
+ Misses 907 899 -8
Partials 143 143 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmartinol
reviewed
Nov 24, 2025
dmartinol
approved these changes
Nov 24, 2025
Collaborator
|
post-merge comment: maybe we could add one sample manifest under examples/? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR adds the managed registry type as per the design doc for the configuration.
Details: