-
Notifications
You must be signed in to change notification settings - Fork 4
Improve ShouldSync return type #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ShouldSync return type #172
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
+ Coverage 65.25% 65.56% +0.31%
==========================================
Files 58 58
Lines 3589 3613 +24
==========================================
+ Hits 2342 2369 +27
+ Misses 1090 1088 -2
+ Partials 157 156 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonburdo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is based on comment #77 (comment)
@blkt Was this roughly what you had in mind? I'm happy to use a different approach if not. This seemed like the simplest, but we could keep reason's as string constants or use a struct like Decision{ShouldSync: false, Reason: "sync-already-in-progress"}
d387fc0 to
833977d
Compare
This changes ShouldSync to return a Reason type instead of three separate values. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Jon Burdo <jon@jonburdo.com>
833977d to
71baca9
Compare
dmartinol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This changes ShouldSync to return a Reason type instead of three separate values.
🤖 Generated with Claude Code
fixes #82