Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

fix: correct problems with ollama and aider#596

Merged
yrobla merged 1 commit into
mainfrom
issue-586
Jan 16, 2025
Merged

fix: correct problems with ollama and aider#596
yrobla merged 1 commit into
mainfrom
issue-586

Conversation

@yrobla

@yrobla yrobla commented Jan 15, 2025

Copy link
Copy Markdown
Contributor

It has a pair of problems:

  • always need to check that the model contains some value
  • only send chunks that contain data, and do not send double newlines as they get considered as a different chunk

Closes: #586

@danbarr

danbarr commented Jan 15, 2025

Copy link
Copy Markdown
Contributor

This resolved the errors I saw with Ollama, however I get pretty unexpected results:

image

@danbarr danbarr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this did something to malicious package detection. Running off this branch, malicious packages aren't being detected at all for me anymore.

It has a pair of problems:
- always need to check that the model contains some value
- only send chunks that contain data, and do not send double newlines
as they get considered as a different chunk

Closes: #586
@jhrozek

jhrozek commented Jan 16, 2025

Copy link
Copy Markdown
Contributor

I think this did something to malicious package detection. Running off this branch, malicious packages aren't being detected at all for me anymore.

Note that if you're running from source, the full malicious database is not available, that's only added when producing the release image. Only packages from https://github.com/stacklok/codegate/blob/main/data/malicious.jsonl and other files in that directory are.

@yrobla

yrobla commented Jan 16, 2025

Copy link
Copy Markdown
Contributor Author

rebased on top of latest patches, and testing again

@yrobla yrobla requested a review from danbarr January 16, 2025 11:33
@yrobla yrobla dismissed danbarr’s stale review January 16, 2025 11:34

please test again, using --model ollama_chat/qwen2.5-coder:7b

@yrobla yrobla merged commit 55cb0a9 into main Jan 16, 2025
@yrobla yrobla deleted the issue-586 branch January 16, 2025 13:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error with Aider and Ollama

4 participants