This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Allow creating database connection wrapper without a singleton #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea is that one would be able to pass the `_no_singleton` boolean flag to the class and if so, the class would be returned without creating a singleton. This is handy for testing, since it would allow for several connections to be open in parallel to different database paths, which indeed is a testing scenario. ``` >>> from codegate.db.connection import DbCodeGate >>> dbc = DbCodeGate(_no_singleton=True) >>> print(dbc) <codegate.db.connection.DbCodeGate object at 0x7f9a0f067650> >>> dbc2 = DbCodeGate(_no_singleton=True) >>> print(dbc2) <codegate.db.connection.DbCodeGate object at 0x7f9a0daad1f0> >>> dbc3 = DbCodeGate() >>> print(dbc3) <codegate.db.connection.DbCodeGate object at 0x7f9a0f065190> >>> dbc4 = DbCodeGate() >>> print(dbc4) <codegate.db.connection.DbCodeGate object at 0x7f9a0f065190> ``` Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
aponcedeleonch
approved these changes
Feb 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is that one would be able to pass the
_no_singletonbooleanflag to the class and if so, the class would be returned without
creating a singleton.
This is handy for testing, since it would allow for several connections
to be open in parallel to different database paths, which indeed is a
testing scenario.
Signed-off-by: Juan Antonio Osorio ozz@stacklok.com