review changes

Signed-off-by: Mauritz Uphoff <mauritz.uphoff@stackit.cloud>

Author: h3adex

stackit/internal/services/observability/cert-check/datasource.go

@@ -43,11 +43,10 @@ func (d *certCheckDataSource) Configure(ctx context.Context, req datasource.Conf
 		return
 	}
 
-	apiClient := observabilityUtils.ConfigureClient(ctx, &providerData, &resp.Diagnostics)
+	d.client = observabilityUtils.ConfigureClient(ctx, &providerData, &resp.Diagnostics)
 	if resp.Diagnostics.HasError() {
 		return
 	}
-	d.client = apiClient
 	tflog.Info(ctx, "Observability client configured")
 }
 

stackit/internal/services/observability/cert-check/resource.go

@@ -74,11 +74,10 @@ func (r *observabilityCertCheckResource) Configure(ctx context.Context, req reso
 		return
 	}
 
-	apiClient := observabilityUtils.ConfigureClient(ctx, &providerData, &resp.Diagnostics)
+	r.client = observabilityUtils.ConfigureClient(ctx, &providerData, &resp.Diagnostics)
 	if resp.Diagnostics.HasError() {
 		return
 	}
-	r.client = apiClient
 	tflog.Info(ctx, "Observability client configured")
 }
 

stackit/internal/services/observability/http-check/datasource.go

@@ -43,11 +43,10 @@ func (d *httpCheckDataSource) Configure(ctx context.Context, req datasource.Conf
 		return
 	}
 
-	apiClient := observabilityUtils.ConfigureClient(ctx, &providerData, &resp.Diagnostics)
+	d.client = observabilityUtils.ConfigureClient(ctx, &providerData, &resp.Diagnostics)
 	if resp.Diagnostics.HasError() {
 		return
 	}
-	d.client = apiClient
 	tflog.Info(ctx, "Observability client configured")
 }
 

stackit/internal/services/observability/http-check/resource.go

@@ -75,11 +75,10 @@ func (r *observabilityHttpCheckResource) Configure(ctx context.Context, req reso
 		return
 	}
 
-	apiClient := observabilityUtils.ConfigureClient(ctx, &providerData, &resp.Diagnostics)
+	r.client = observabilityUtils.ConfigureClient(ctx, &providerData, &resp.Diagnostics)
 	if resp.Diagnostics.HasError() {
 		return
 	}
-	r.client = apiClient
 	tflog.Info(ctx, "Observability client configured")
 }
 

stackit/provider.go

@@ -498,7 +498,6 @@ func (p *Provider) DataSources(_ context.Context) []func() datasource.DataSource
 		iaasalphaRoutingTables.NewRoutingTablesDataSource,
 		iaasalphaRoutingTableRoutes.NewRoutingTableRoutesDataSource,
 		iaasVolume.NewVolumeDataSource,
-		iaasSecurityGroupRule.NewSecurityGroupRuleDataSource,
 		kmsKey.NewKeyDataSource,
 		kmsKeyRing.NewKeyRingDataSource,
 		kmsWrappingKey.NewWrappingKeyDataSource,