Extend Load Balancer creation waiter to look for errors in Errors field (#354)

* Extend Load Balancer creation waiter to look for errors in `Errors` field

* Fix date in changelog

* Re-add comment removed by mistake

* Add status to error message; Improve changelog

Author: joaopalet

services/loadbalancer/CHANGELOG.md

@@ -1,3 +1,7 @@
+## v0.9.3 (2024-03-19)
+
+- Improve error handling in Load Balancer creation waiter, fixing timeout being exceeded for `STATUS_PENDING` status with errors. If an error is found in the `Errors` field, the waiter now returns with error.
+
 ## v0.9.2 (2024-02-28)
 
 - Update `core` to [`v0.10.0`](../../core/CHANGELOG.md#v0100-2024-02-27)

services/loadbalancer/wait/wait.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"net/http"
+	"strings"
 	"time"
 
 	"github.com/stackitcloud/stackit-sdk-go/core/oapierror"
@@ -46,6 +47,15 @@ func CreateLoadBalancerWaitHandler(ctx context.Context, a APIClientInterface, pr
 		if s == nil || s.Name == nil || *s.Name != instanceName || s.Status == nil {
 			return false, nil, nil
 		}
+
+		var errors []string
+		if s.Errors != nil && len(*s.Errors) > 0 {
+			for _, err := range *s.Errors {
+				errors = append(errors, fmt.Sprintf("%s: %s", *err.Type, *err.Description))
+			}
+			return true, s, fmt.Errorf("create failed for instance with name %s, got status %s and errors: %s", instanceName, *s.Status, strings.Join(errors, ";"))
+		}
+
 		switch *s.Status {
 		case InstanceStatusReady:
 			return true, s, nil