Skip to content

fix node/partition definitions for single compute node #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2020
Merged

fix node/partition definitions for single compute node #26

merged 1 commit into from
Apr 24, 2020

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Apr 11, 2020

Modify handling of node names in slurm.conf.j2 to allow creating clusters with only a single compute node, e.g. openhpc-compute-0 rather than openhpc-compute-[0-0] as currently generated.

@sjpb sjpb requested a review from brtkwr April 11, 2020 12:16
@sjpb
Copy link
Collaborator Author

sjpb commented Apr 11, 2020

Tested on 1 and 3-node clusters.

@sjpb
Copy link
Collaborator Author

sjpb commented Apr 17, 2020

Closes #20

oneswig
oneswig approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@oneswig oneswig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jinja templating syntax - it's not the best for readability, but I think this is good.

@sjpb sjpb merged commit 952ae6e into master Apr 24, 2020
@sjpb sjpb mentioned this pull request Apr 24, 2020
Closed
@sjpb sjpb deleted the issue20 branch November 3, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oneswig oneswig oneswig approved these changes

@brtkwr brtkwr Awaiting requested review from brtkwr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjpb @oneswig