Skip to content

Fix slurm.conf jinja templating #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Fix slurm.conf jinja templating #179

merged 2 commits into from
Apr 22, 2025

Conversation

bertiethorpe
Copy link
Member

trim_blocks on by default in Ansible so extra newline required at end of template tag

#170 (comment)

trim_blocks on by default in Ansible so extra newline required at end of template tag
@bertiethorpe bertiethorpe requested a review from a team as a code owner April 22, 2025 14:25
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bertiethorpe bertiethorpe requested a review from sjpb April 22, 2025 15:37
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb enabled auto-merge (squash) April 22, 2025 15:49
@sjpb sjpb self-requested a review April 22, 2025 15:50
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 3e3976b into master Apr 22, 2025
31 checks passed
@sjpb sjpb deleted the fix/slurm-conf-template branch April 22, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants